Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add config-ssh command #735

Merged
merged 2 commits into from
Mar 30, 2022
Merged

feat: Add config-ssh command #735

merged 2 commits into from
Mar 30, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Mar 30, 2022

Closes #254, #499, and #737.

@kylecarbs kylecarbs requested a review from coadler March 30, 2022 14:39
@kylecarbs kylecarbs self-assigned this Mar 30, 2022
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #735 (6b0c76d) into main (1bab7e8) will decrease coverage by 0.58%.
The diff coverage is 57.76%.

@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
- Coverage   64.53%   63.95%   -0.59%     
==========================================
  Files         198      199       +1     
  Lines       11622    11826     +204     
  Branches       85       87       +2     
==========================================
+ Hits         7500     7563      +63     
- Misses       3333     3437     +104     
- Partials      789      826      +37     
Flag Coverage Δ
unittest-go- 63.03% <54.51%> (-0.58%) ⬇️
unittest-go-macos-latest 58.85% <54.34%> (-0.65%) ⬇️
unittest-go-ubuntu-latest 61.79% <54.51%> (-0.41%) ⬇️
unittest-go-windows-2022 58.03% <53.62%> (-0.32%) ⬇️
unittest-js 62.63% <ø> (-0.70%) ⬇️
Impacted Files Coverage Δ
agent/conn.go 65.38% <ø> (-3.59%) ⬇️
cli/workspacedelete.go 17.64% <0.00%> (ø)
cli/workspacestart.go 15.15% <0.00%> (ø)
cli/workspacestop.go 13.88% <0.00%> (ø)
provisioner/terraform/provision.go 68.82% <0.00%> (ø)
coderd/workspaceresources.go 56.09% <26.92%> (-5.45%) ⬇️
cli/ssh.go 38.88% <35.00%> (-4.45%) ⬇️
cli/start.go 65.74% <50.00%> (-0.42%) ⬇️
cli/configssh.go 58.03% <55.23%> (+0.89%) ⬆️
cli/cliui/agent.go 82.45% <70.00%> (+0.31%) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bab7e8...6b0c76d. Read the comment docs.

agent/agent.go Outdated Show resolved Hide resolved
cli/cliui/agent.go Show resolved Hide resolved
cli/configssh.go Show resolved Hide resolved
cli/configssh.go Show resolved Hide resolved
cli/configssh.go Outdated Show resolved Hide resolved
@kylecarbs kylecarbs force-pushed the config-ssh branch 2 times, most recently from 67dda0d to 550ba6f Compare March 30, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup SSH config for Workspaces
2 participants