Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set patch coverage to informational (always pass status check) #75

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

bryphe-coder
Copy link
Contributor

Came up in our 1:1 discussion - we have cases where the patch diff might not hit the coverage goal, but it doesn't overall coverage. An example would be changing a single line in a /pages component to fix a typo - that would have 0% coverage, but not impact overall coverage.

This just sets the patch check to informational, so the status check always passes (it still reports the diff %, though, which is useful for cases in general): https://docs.codecov.com/docs/commit-status#patch-status

@bryphe-coder bryphe-coder self-assigned this Jan 26, 2022
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #75 (f159f8b) into main (0c46cbf) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   71.97%   72.12%   +0.14%     
==========================================
  Files          88       88              
  Lines        3422     3422              
  Branches       55       55              
==========================================
+ Hits         2463     2468       +5     
+ Misses        751      747       -4     
+ Partials      208      207       -1     
Flag Coverage Δ
unittest-go-macos-latest 67.73% <ø> (+0.28%) ⬆️
unittest-go-ubuntu-latest 69.63% <ø> (+0.03%) ⬆️
unittest-go-windows-latest 67.19% <ø> (-0.04%) ⬇️
unittest-js 78.30% <ø> (ø)
Impacted Files Coverage Δ
peer/conn.go 77.24% <0.00%> (+0.59%) ⬆️
peerbroker/listen.go 82.81% <0.00%> (+2.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c46cbf...f159f8b. Read the comment docs.

@bryphe-coder bryphe-coder merged commit f970e35 into main Jan 26, 2022
@bryphe-coder bryphe-coder deleted the bryphe/chore/patch-coverage-informational branch January 26, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants