Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix race in collecting ICE Candidates #76

Merged
merged 5 commits into from
Jan 27, 2022
Merged

chore: Fix race in collecting ICE Candidates #76

merged 5 commits into from
Jan 27, 2022

Conversation

kylecarbs
Copy link
Member

This logic was flawed previously. ICE Candidates could collect
before a negotiation was triggered, which led to a race where
candidates would be lost. Candidates can no longer be lost,
and we removed some code 馃槑.

This logic was flawed previously. ICE Candidates could collect
before a negotiation was triggered, which led to a race where
candidates would be lost. Candidates can no longer be lost,
and we removed some code 馃槑.
@kylecarbs kylecarbs self-assigned this Jan 26, 2022
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #76 (f477308) into main (f970e35) will increase coverage by 0.07%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   71.88%   71.96%   +0.07%     
==========================================
  Files          88       88              
  Lines        3422     3406      -16     
  Branches       55       55              
==========================================
- Hits         2460     2451       -9     
+ Misses        753      748       -5     
+ Partials      209      207       -2     
Flag Coverage 螖
unittest-go-macos-latest 67.40% <92.30%> (-0.05%) 猬囷笍
unittest-go-ubuntu-latest 69.61% <92.30%> (-0.21%) 猬囷笍
unittest-go-windows-latest 67.00% <92.30%> (-0.12%) 猬囷笍
unittest-js 78.30% <酶> (酶)
Impacted Files Coverage 螖
peer/conn.go 76.72% <90.47%> (+0.98%) 猬嗭笍
peer/channel.go 87.11% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f970e35...f477308. Read the comment docs.

Copy link
Contributor

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on another race condition @kylecarbs !

@kylecarbs kylecarbs merged commit 9329a50 into main Jan 27, 2022
@kylecarbs kylecarbs deleted the peerrace branch January 27, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants