Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dogfood): Update sqlc version in dogfood image to match CI #7661

Merged
merged 1 commit into from
May 24, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented May 24, 2023

We were not using the same version of sqlc in the dogfood image Dockerfile as we are using in CI, leading to test failures when running make gen.

…ed in CI

We were not using the same version of sqlc in the dogfood image Dockerfile as we are using in CI, leading to test failures when running `make gen`.
@johnstcn johnstcn self-assigned this May 24, 2023
@johnstcn johnstcn changed the title chore(dogfood): Update sqlc version in dogfood image to match that us… chore(dogfood): Update sqlc version in dogfood image to match CI May 24, 2023
@matifali matifali added bug s3 Bugs that confuse, annoy, or are purely cosmetic labels May 24, 2023
Copy link
Collaborator

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@matifali matifali enabled auto-merge (squash) May 24, 2023 09:28
@matifali matifali merged commit f47ecc2 into main May 24, 2023
33 checks passed
@matifali matifali deleted the cj/dogfood-bump-sqlc branch May 24, 2023 09:30
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2023
@matifali matifali added the bug Used to filter all bug issues label Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Used to filter all bug issues s3 Bugs that confuse, annoy, or are purely cosmetic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants