Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Build Windows releases with zip archives #823

Merged
merged 1 commit into from Apr 1, 2022
Merged

fix: Build Windows releases with zip archives #823

merged 1 commit into from Apr 1, 2022

Conversation

kylecarbs
Copy link
Member

A much better UX for our Windows folk!

@kylecarbs kylecarbs self-assigned this Apr 1, 2022
A much better UX for our Windows folk!
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #823 (3372464) into main (efec029) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #823      +/-   ##
==========================================
- Coverage   64.19%   64.03%   -0.17%     
==========================================
  Files         199      199              
  Lines       11841    11841              
  Branches       87       87              
==========================================
- Hits         7601     7582      -19     
- Misses       3419     3434      +15     
- Partials      821      825       +4     
Flag Coverage Δ
unittest-go- 63.07% <ø> (-0.22%) ⬇️
unittest-go-macos-latest 59.00% <ø> (+0.14%) ⬆️
unittest-go-ubuntu-latest 61.65% <ø> (-0.17%) ⬇️
unittest-go-windows-2022 58.07% <ø> (-0.06%) ⬇️
unittest-js 62.63% <ø> (ø)
Impacted Files Coverage Δ
coderd/parameter/compute.go 74.07% <0.00%> (-4.45%) ⬇️
coderd/provisionerdaemons.go 60.03% <0.00%> (-3.55%) ⬇️
provisionerd/provisionerd.go 80.32% <0.00%> (-1.33%) ⬇️
peer/conn.go 78.42% <0.00%> (-0.51%) ⬇️
coderd/workspaceresources.go 59.34% <0.00%> (+4.47%) ⬆️
coderd/httpapi/httpapi.go 72.50% <0.00%> (+6.25%) ⬆️
provisionersdk/transport.go 85.10% <0.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efec029...3372464. Read the comment docs.

@kylecarbs kylecarbs enabled auto-merge (squash) April 1, 2022 19:32
@kylecarbs kylecarbs merged commit cbb82ce into main Apr 1, 2022
@kylecarbs kylecarbs deleted the windowzip branch April 1, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants