Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not wait for devcontainer template volume claim bound #8539

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

Tirzono
Copy link
Contributor

@Tirzono Tirzono commented Jul 17, 2023

Most of the other templates have this line in their templates. Without this line for me it would hang starting a workspace as the pod waits for the pvc and the pvc waits for the pod.

@cdr-bot cdr-bot bot added the community Pull Requests created by the community. label Jul 17, 2023
@github-actions
Copy link

github-actions bot commented Jul 17, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Tirzono
Copy link
Contributor Author

Tirzono commented Jul 17, 2023

I have read the CLA Document and I hereby sign the CLA

cdrcommunity added a commit to coder/cla that referenced this pull request Jul 17, 2023
@matifali matifali requested a review from bpmct July 17, 2023 09:53
@kylecarbs kylecarbs enabled auto-merge (squash) July 17, 2023 14:57
@kylecarbs kylecarbs merged commit a28883d into coder:main Jul 23, 2023
20 of 21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Pull Requests created by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants