feat(cli): check if dotfiles install script is executable

[BRAVO68WEB]

Problem Statement

So I was having an issue regarding the installation of dotfiles. Everything was working fine until an install script was executed. This install script was installing system dependencies and using sudo commands. Hence, I was getting permission denied.

Solution

I added a code snippet just before the scripts were executed.

PS: Sorry, I didn't create an Issue first.

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[BRAVO68WEB]

I have read the CLA Document and I hereby sign the CLA

[mafredri]

Thanks for the contribution! I do wonder whether or not we should do this, though. This will introduce a local change into the repo being checked out (git tracks executable bit on files). Another solution would be to chmod +x bootstrap.sh && git add bootstrap.sh && git commit in your personal repo.

Perhaps it would be safer to check the executable bit and print a pretty error explaining how to fix it? We could also run scripts via interpreter like /bin/sh, etc, but this would also require checking potential shebang (#!/bin/other) at the top of the script. And doing that might also not work properly on Windows.

[BRAVO68WEB]

Hmm.. Let me look into it

[BRAVO68WEB]

This will introduce a local change into the repo being checked out (git tracks executable bit on files). Another solution would be to chmod +x bootstrap.sh && git add bootstrap.sh && git commit in your personal repo.

Yes, you are correct in that case.

So, I found this on StackOverflow.

Shall I set a git config, so that such changes are ignored, for the dotfiles cloned repo?

Perhaps it would be safer to check the executable bit and print a pretty error explaining how to fix it?

Yes, can be done too.

I am unable to choose which would be a better solution.

[BRAVO68WEB]

Yeah on second thoughts, 2nd solution would be better. Check for exec bits, and notify user about the same. I am changing this, and pushing

[BRAVO68WEB]

@mafredri Can you review it!

[BRAVO68WEB]

I will also try to update docs.

[BRAVO68WEB]

@mafredri I have added to docs about the same

[BRAVO68WEB]

Added all suggested changes.

[mafredri]

I may have had some grammar nits, but all in all, excellent work! Thanks a lot for your contribution and going the extra mile! ☺️