feat: add "dormant" user state #8644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Aug 2, 2023
johnstcn
reviewed
Aug 2, 2023
johnstcn
reviewed
Aug 2, 2023
johnstcn
reviewed
Aug 2, 2023
johnstcn
reviewed
Aug 2, 2023
johnstcn
reviewed
Aug 2, 2023
johnstcn
reviewed
Aug 2, 2023
Comment on lines
48
to
63
| require.Eventually(t, func() bool { | ||
| rows, err = db.GetUsers(ctx, database.GetUsersParams{}) | ||
| if err != nil { | ||
| return false | ||
| } | ||
|
|
||
| var c int | ||
| for _, row := range rows { | ||
| if row.Status == database.UserStatusDormant { | ||
| c++ | ||
| } | ||
| } | ||
| // 6 users in total, 3 dormant | ||
| return len(rows) == 6 && c == 3 | ||
| }, testutil.WaitShort, testutil.IntervalMedium) | ||
|
|
There was a problem hiding this comment.
Suggestion: if you allow passing in a tick chan time.Time and updated chan int into CheckInactiveUsersWithOptions you can then conceivably remove this require.Eventually - you write a time to tick, and read the number of updated users from updated
There was a problem hiding this comment.
This is a good hint in case we want to do something more with these accounts than validate in unit tests. I would keep it simple as is.
johnstcn
reviewed
Aug 2, 2023
| SET | ||
| user_status = 'dormant'::user_status | ||
| WHERE | ||
| last_seen_at < @last_seen_after :: timestamp |
There was a problem hiding this comment.
note for readers: this is correct as last_seen_at is timestamp without time zone.
johnstcn
approved these changes
Aug 2, 2023
johnstcn
reviewed
Aug 2, 2023
johnstcn
approved these changes
Aug 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #8128
This PR officially introduces another user account status -
dormant. Users who have not logged in yet to the Coder platform will be marked as dormant, and will not be included in the license seat calculations.Low-level changes:
dormantuser statusExtractAPIKeyMWto switch a "dormant" account to "active"Testing:
@coder.comGoogle accountNotes:
Next steps: