Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(site): add auto mode on create workspace form #8651

Merged
merged 24 commits into from
Jul 27, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented Jul 21, 2023

Closes #7717

@BrunoQuaresma BrunoQuaresma self-assigned this Jul 21, 2023
@coder coder deleted a comment from BrunoQuaresma Jul 21, 2023
@MrPeacockNLB
Copy link
Contributor

Super cool! Can't await this feature!

Hopefully I'll find some time to public release the coder button as well. In conjuntion with this feature make really sense

@coder coder deleted a comment from BrunoQuaresma Jul 24, 2023
@bpmct
Copy link
Member

bpmct commented Jul 24, 2023

@matifali can take a look tomorrow :)

@coder coder deleted a comment from bpmct Jul 25, 2023
@coder coder deleted a comment from github-actions bot Jul 25, 2023
@coder coder deleted a comment from BrunoQuaresma Jul 25, 2023
@matifali matifali self-requested a review July 25, 2023 04:44
Copy link
Collaborator

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bpmct and @BrunoQuaresma I did deploy this, but I don't see any difference in the behavior compared to dev.coder.com
Maybe I am missing something. Do you know if I need to specify or enable something specifically?

matifali
matifali previously approved these changes Jul 25, 2023
Copy link
Collaborator

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets me to this form
image

@matifali matifali dismissed their stale review July 25, 2023 05:42

not working as expected

@coder coder deleted a comment from BrunoQuaresma Jul 25, 2023
@coder coder deleted a comment from BrunoQuaresma Jul 25, 2023
@coder coder deleted a comment from github-actions bot Jul 25, 2023
@coder coder deleted a comment from github-actions bot Jul 26, 2023
@coder coder deleted a comment from github-actions bot Jul 26, 2023
@coder coder deleted a comment from github-actions bot Jul 26, 2023
@bpmct
Copy link
Member

bpmct commented Jul 26, 2023

Is there a way to specify a name via a URL parameter? If taken, it appends a random name?

Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 but there is one question from Ben that might be relevant.

@BrunoQuaresma
Copy link
Collaborator Author

@bpmct Yes, you can use the ?name=something and if the name is taken you will be asked to add a new name but I don't see why this would be a good thing to do since the idea of a link would have multiple ppl using it, so the name only would work at the first time.

Mergin it for now but I can do a hotfix if it is required. Ps: It would one more step to validate the name.

@BrunoQuaresma BrunoQuaresma merged commit f54d385 into main Jul 27, 2023
21 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/one-click-workspace branch July 27, 2023 11:48
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

open on coder button without subbmitting the form
5 participants