Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm)!: set enableDeployments default to true #8704

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

ericpaulsen
Copy link
Member

@ericpaulsen ericpaulsen commented Jul 24, 2023

as we move toward rolling out logstream-kube solution, setting enableDeployments: true as the default will remove a step for customers who are looking to migrate workspace to Deployments.

NOTE: this is a breaking change in our Helm chart.

@ericpaulsen ericpaulsen added the feature Something we don't have yet label Jul 24, 2023
@ericpaulsen ericpaulsen requested a review from bpmct July 24, 2023 20:39
@ericpaulsen ericpaulsen self-assigned this Jul 24, 2023
@ericpaulsen ericpaulsen changed the title helm: set enableDeployments default to true feat(helm): set enableDeployments default to true Jul 24, 2023
@bpmct bpmct added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Jul 24, 2023
@github-actions github-actions bot changed the title feat(helm): set enableDeployments default to true feat(helm)!: set enableDeployments default to true Jul 24, 2023
@bpmct bpmct merged commit 2996343 into main Jul 24, 2023
37 checks passed
@bpmct bpmct deleted the deployment-rbac-default branch July 24, 2023 22:13
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Something we don't have yet release/breaking This label is applied to PRs to detect breaking changes as part of the release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants