Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move oidc from experimental to ga #8742

Merged
merged 2 commits into from
Jul 31, 2023
Merged

feat: move oidc from experimental to ga #8742

merged 2 commits into from
Jul 31, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jul 26, 2023 •
edited

Closes #8327

Feature is always on

PRs for feature:

Future Work

  • Handing email mismatch. Right now, if the emails do not match, we block the conversion attempt.
    • I think a solution to this is allowing admins to change emails on account. Right now we do not allow user's to change their email, so it should require an admin action.
  • You cannot go back to password auth.
    • This should only be able to be done by admins.

@Emyrk Emyrk marked this pull request as ready for review July 26, 2023 17:31
@Emyrk Emyrk changed the title feat: convert to oidc out of experimental feat: move oidc from experimental to ga Jul 26, 2023
@Emyrk Emyrk requested a review from bpmct July 26, 2023 18:28
@Emyrk
Copy link
Member Author

Emyrk commented Jul 26, 2023

@bpmct can you green check this when you are ok to merge it from a releases perspective?

@Emyrk Emyrk requested a review from johnstcn July 26, 2023 18:29
johnstcn
johnstcn approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

bpmct
bpmct approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may have missed it, but can you add back

You can convert your account to use this login type by visiting your account settings.

That I removed in #8695

@Emyrk Emyrk merged commit cb36783 into main Jul 31, 2023
22 of 23 checks passed
@Emyrk Emyrk deleted the stevenmasley/convert_oidc_ga branch July 31, 2023 15:30
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@bpmct bpmct bpmct approved these changes

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bring "Convert to OIDC" out of experimental
3 participants
@Emyrk @johnstcn @bpmct