Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix tailnet netcheck issues #8802

Merged
merged 5 commits into from
Aug 1, 2023
Merged

fix: fix tailnet netcheck issues #8802

merged 5 commits into from
Aug 1, 2023

Conversation

deansheather
Copy link
Member

  • Add STUN nodes to every Coder-managed DERP region (previously was only the primary region).
    • This means that regardless of which DERP region is selected, tailscale will always try to do STUN. Previously (AFAIK) if
  • Avoid adding port to DERP URL in healthcheck if it's the default port for the URL scheme.
  • Rework tailnet connection accept mechanism so we can update tailscale dependency.

Depends on coder/tailscale#28 and coder/tailscale#29 which:

  • Fixes DERP healthcheck on non-standard HTTP(S) ports (in compliment with the second point above)
  • Avoids using STUN latency as the indicator for the region latency. This means that HTTP(S) latency checks are always performed on every region.
  • Fixes ForceHTTP nodes in netcheck

- Add STUN nodes to every Coder-managed DERP region (previously was only
  the primary region).
- Avoid adding port to DERP URL in healthcheck if it's the default port
  for the URL scheme.
- Rework tailnet connection accept mechanism so we can update tailscale
  dependency.
@deansheather deansheather merged commit c575292 into main Aug 1, 2023
20 checks passed
@deansheather deansheather deleted the dean/fix-netcheck branch August 1, 2023 15:50
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants