refactor: Improve handshake resiliency of peer #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 71.65% 72.15% +0.50%
==========================================
Files 89 89
Lines 3612 3627 +15
Branches 55 55
==========================================
+ Hits 2588 2617 +29
+ Misses 799 791 -8
+ Partials 225 219 -6
Continue to review full report at Codecov.
|
|
Going to be bad and use admin privileges to merge this. The peer flake is actively hurting other PRs, so seems reasonable. |
jawnsy
approved these changes
Jan 30, 2022
jawnsy
reviewed
Jan 30, 2022
kylecarbs
force-pushed
the
peerlog
branch
2 times, most recently
from
9758be4
to
1c61fef
Compare
We were depending on the close mutex to properly report connection state. This ensures the RTC connection is properly closed before returning.
kylecarbs
force-pushed
the
peerlog
branch
3 times, most recently
from
00f49f3
to
3367212
Compare
kylecarbs
force-pushed
the
peerlog
branch
3 times, most recently
from
006ab67
to
8b33e86
Compare
kylecarbs
force-pushed
the
peerlog
branch
12 times, most recently
from
b493807
to
e5cb06b
Compare
kylecarbs
force-pushed
the
peerlog
branch
2 times, most recently
from
c5c8b65
to
b69f269
Compare
kylecarbs
force-pushed
the
peerlog
branch
2 times, most recently
from
7df4cc9
to
e87d2cb
Compare
kylecarbs
force-pushed
the
peerlog
branch
2 times, most recently
from
93ce57e
to
9ef1d89
Compare
kylecarbs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were depending on the close mutex to properly
report connection state. This ensures the RTC
connection is properly closed before returning.