This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Firefox extension #243
Merged
Firefox extension #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed install-for-chrome-ext to install-ext-host, added Firefox support and added a new deprecated command alias for the old name. Co-authored-by: Luca Casonato <luca.casonato@antipy.com>
kylecarbs
approved these changes
Sep 17, 2019
sr229
reviewed
Sep 17, 2019
| } | ||
| nativeHostDirsChrome, err := nativeMessageHostManifestDirectoriesChrome() | ||
| if err != nil { | ||
| flog.Fatal("failed to get chrome native message host manifest directory: %v", err) |
There was a problem hiding this comment.
Probably a more generic message here sincr we're aiming for two vendors
| @@ -15,10 +15,6 @@ The Sail browser extension allows you to open GitHub or GitLab projects with a s | |||
| ## Install | |||
|
|
|||
| 1. [Install Sail if you haven't already](/docs/installation) | |||
| 1. Run `sail install-for-chrome-ext` to install the chrome extension manifest.json | |||
| 1. Run `sail install-ext-host` to install the extension manifest.json | |||
| 1. [Install the extension from the Chrome Marketplace](https://chrome.google.com/webstore/detail/sail/deeepphleikpinikcbjplcgojfhkcmna) | |||
There was a problem hiding this comment.
Make sure you edit this post merge for the Firefox extensions link.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Firefox support to the native host installer and makes the extension web extensions compatible.
#225