fix(auth) check for password length of 0 #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found myself in a vicious loop if I failed to type in a password when prompted in Chrome. Every refresh of the page would fall into the criton check with a blank password. Seems Chrome wouldn't clear the headers until I closed the browser and/or switched to a new incognito tab. Probably a user error, but still, this avoided the criton throw.
|
There were the following issues with your Pull Request
Guidelines are available at https://github.com/coderaiser/cloudcmd/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
|
Thank you, merged as eceb0ac. |
|
Landed in v5.6.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] commit message named according to Contributing Guide
[x]
npm run codestyleis OK[x]
npm testis OKCheck for a non-zero length password before making the call to criton for hash verification.
If the user attempts to login in when authorization is enabled and fails to supply a password, the headers don't get properly cleared (in Chrome) leading to an unescapable loop even when stopping and restarting the service.