Feature streamforms #171
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| from django.utils.translation import ugettext_lazy as _ | ||
| from wagtail.core import blocks | ||
|
|
||
|
|
||
| from coderedcms.wagtail_flexible_forms import blocks as form_blocks | ||
| from coderedcms.blocks.base_blocks import BaseBlock, CoderedAdvSettings | ||
| from coderedcms.forms import SecureFileField | ||
|
|
||
|
|
||
| class CoderedFormAdvSettings(CoderedAdvSettings): | ||
|
|
||
| conditional_name = blocks.CharBlock( | ||
| required=False, | ||
| max_length=255, | ||
| label=_('Conditional Name'), | ||
| help_text=_('The name used to identify this block for other blocks to target as a condition.') | ||
| ) | ||
| conditional_target_name = blocks.CharBlock( | ||
| required=False, | ||
| max_length=255, | ||
| label=_('Conditional Target Name'), | ||
| help_text=_('The name of the block that will be this block\'s condition.') | ||
| ) | ||
| conditional_target_value = blocks.CharBlock( | ||
| required=False, | ||
| max_length=255, | ||
| label=_('Conditional Target Value'), | ||
| help_text=_('The value of this block\'s condition that is required to show this block on the form.') | ||
| ) | ||
|
|
||
|
|
||
| class FormBlockMixin(BaseBlock): | ||
| class Meta: | ||
| abstract=True | ||
|
|
||
| advsettings_class = CoderedFormAdvSettings | ||
|
|
||
|
|
||
| class CoderedAdvancedFormFieldBlock(form_blocks.OptionalFormFieldBlock, FormBlockMixin): | ||
| pass | ||
|
|
||
|
|
||
| class CoderedAdvancedFormCharFieldBlock(form_blocks.CharFieldBlock, FormBlockMixin): | ||
| pass | ||
|
|
||
|
|
||
| class CoderedAdvancedFormTextFieldBlock(form_blocks.TextFieldBlock, FormBlockMixin): | ||
| pass | ||
|
|
||
|
|
||
| class CoderedAdvancedFormNumberFieldBlock(form_blocks.NumberFieldBlock, FormBlockMixin): | ||
| pass | ||
|
|
||
|
|
||
| class CoderedAdvancedFormCheckboxFieldBlock(form_blocks.CheckboxFieldBlock, FormBlockMixin): | ||
| pass | ||
|
|
||
|
|
||
| class CoderedAdvancedFormRadioButtonsFieldBlock(form_blocks.RadioButtonsFieldBlock, FormBlockMixin): | ||
| pass | ||
|
|
||
|
|
||
| class CoderedAdvancedFormDropdownFieldBlock(form_blocks.DropdownFieldBlock, FormBlockMixin): | ||
| pass | ||
|
|
||
|
|
||
| class CoderedAdvancedFormCheckboxesFieldBlock(form_blocks.CheckboxesFieldBlock, FormBlockMixin): | ||
| pass | ||
|
|
||
|
|
||
| class CoderedAdvancedFormDateFieldBlock(form_blocks.DateFieldBlock, FormBlockMixin): | ||
|
There was a problem hiding this comment. Not sure if the problem is here, but the Date/Time/Datetime blocks are not rendering with the correct html |
||
| pass | ||
|
|
||
|
|
||
| class CoderedAdvancedFormTimeFieldBlock(form_blocks.TimeFieldBlock, FormBlockMixin): | ||
| pass | ||
|
|
||
|
|
||
| class CoderedAdvancedFormDateTimeFieldBlock(form_blocks.DateTimeFieldBlock, FormBlockMixin): | ||
| pass | ||
|
|
||
|
|
||
| class CoderedAdvancedFormImageFieldBlock(form_blocks.ImageFieldBlock, FormBlockMixin): | ||
| pass | ||
|
|
||
|
|
||
| class CoderedAdvancedFormFileFieldBlock(form_blocks.FileFieldBlock, FormBlockMixin): | ||
| field_class = SecureFileField | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Generated by Django 2.2 on 2019-04-30 21:06 | ||
|
|
||
| from django.db import migrations | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('wagtail_flexible_forms', '__first__'), | ||
| ('coderedcms', '0014_classifiers'), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.CreateModel( | ||
| name='CoderedSessionFormSubmission', | ||
| fields=[ | ||
| ], | ||
| options={ | ||
| 'proxy': True, | ||
| 'indexes': [], | ||
| }, | ||
| bases=('wagtail_flexible_forms.sessionformsubmission',), | ||
| ), | ||
| ] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So my concern here is that this will potentially cause migrations from hell once we have to switch to built-in wagtail streamforms. I'm wondering if we should wrap/extend any blocks or concrete models in
wagtail_flexible_forms, that way all the migrations are pointing to our models, and we can update under the hood as necessary. I only say that because a similar thing happened when we switched from wagtail's built-in RichTextBlock to our own RichTextBlock, and I had to do a bunch of find&replace in migration files in client projects to resolve.I'm not 100% sure if it will cause problems or not, just trying to be proactive. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CoderedAdvancedFormPageuses the extendedCoderedFormStepBlockwhich inherits from theirFormStepBlock. All of our File Fields are using extended versions of their file fields. The only thing that we might want to do related to this concern is to only use wff as a library and extend theirStreamFormMixinandStep/Stepsclasses in the CMS so there is no direct contact between the CMS and wff.