Fix StreamForm submissions #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamForms have been broken in 1.x, however they are seldomly used. I noticed this after testing them with Wagtail 4, apparently, they were broken by Wagtail 3.
In the event that anyone was using StreamForms with 1.x, I have included a sample migration to fix the state of their database. However it is not being included with coderedcms, because I wouldn't want to blindly change
FormSubmissionobjects (which is part of Wagtail, and used by other forms as well). There is also a chance the site is using a custom submission model, in which case the migration could not exist in coderedcms. If the site is experiencing an error caused by this bug, they should apply the migration themselves targeting the affected models.