Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX / Chrome 44 / US English - language preference not properly detected #56

Closed
twanlass opened this issue Aug 21, 2015 · 1 comment
Closed

Comments

@twanlass
Copy link

  1. Navigate to: chrome://settings/languages
  2. Add 'Spanish' to the list (or any other language)
  3. Drag 'Spanish' to the top
  4. Restart Chrome
  5. Console: navigator.language
    Result: "en-US"

This looks to be an issue w/ how you're detecting the language:
https://github.com/coderifous/jquery-localize/blob/master/src/jquery.localize.coffee#L20

A simple fix to this line would be:

JS

$.defaultLanguage = normaliseLang(navigator.languages? navigator.languages[0] : (navigator.language || navigator.userLanguage));

CS

$.defaultLanguage = normaliseLang(if navigator.languages then navigator.languages[0] else navigator.language or navigator.userLanguage)

I'll open a pull-request once I've had a chance to test further!

@coderifous
Copy link
Owner

Merged. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants