Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asio check in SConstruct needs updating #631

Closed
hydrapolic opened this issue Dec 9, 2022 · 2 comments
Closed

asio check in SConstruct needs updating #631

hydrapolic opened this issue Dec 9, 2022 · 2 comments

Comments

@hydrapolic
Copy link

Currently SConstruct mentions:
context.Message('Checking ASIO version (>= 1.10.8 and < 1.11.0) ... ')

For in-system asio. However asio was upgraded to 1.22.1 (60d5e4c) and later downgraded to 1.14.1 (f90cad1), so the check probably needs to be updated.

hydrapolic added a commit to hydrapolic/gentoo-1 that referenced this issue Dec 9, 2022
Galera updated to ASIO 1.22.1:
codership/galera@60d5e4c

However, later they downgraded to 1.14.1:
codership/galera@f90cad1

"Asio versions higher or equal than 1.16.1 require
OpenSSL 1.0.2 or higher. However, some old platforms still in use
have older OpenSSL libraries."

However SConstruct wasn't updated.

codership/galera#631

Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
hydrapolic added a commit to hydrapolic/gentoo-1 that referenced this issue Dec 9, 2022
Galera updated to ASIO 1.22.1:
codership/galera@60d5e4c

However, later they downgraded to 1.14.1:
codership/galera@f90cad1

"Asio versions higher or equal than 1.16.1 require
OpenSSL 1.0.2 or higher. However, some old platforms still in use
have older OpenSSL libraries."

However SConstruct wasn't updated.

codership/galera#631

Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Dec 14, 2022
Galera updated to ASIO 1.22.1:
codership/galera@60d5e4c

However, later they downgraded to 1.14.1:
codership/galera@f90cad1

"Asio versions higher or equal than 1.16.1 require
OpenSSL 1.0.2 or higher. However, some old platforms still in use
have older OpenSSL libraries."

However SConstruct wasn't updated.

codership/galera#631

Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
Closes: #28620
Signed-off-by: Sam James <sam@gentoo.org>
@temeo
Copy link
Contributor

temeo commented Jan 23, 2023

Is there any reason to stick with SCons builds anymore? CMake based builds have been in place for over two years now.

@hydrapolic
Copy link
Author

Sorry I haven't noticed the transition to cmake, I'll try to update our ebuild to cmake, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants