Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-builds success depends on build environment (TLS timeout case) #647

Closed
ottok opened this issue Oct 1, 2023 · 3 comments
Closed

Post-builds success depends on build environment (TLS timeout case) #647

ottok opened this issue Oct 1, 2023 · 3 comments
Assignees

Comments

@ottok
Copy link
Contributor

ottok commented Oct 1, 2023

Debian has a system checking for build reproducibility. Currently it shows that latest version of Galera does not build if the build environment is slightly different.

See https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/galera-4.html

image

The difference between build 1 and build 2 is visible in https://tests.reproducible-builds.org/debian/logdiffs/unstable/amd64/galera-4_26.4.16-1.diff.gz

The purpose of the post-build test is to catch code regressions. Thus it should not have the behavior that is passes on one build and fails on another build with slightly different environment (build dependencies are still the same, but e.g. build time or path might have changed). Hence I would classify this as a bug that the test is not 'stable' enough.

Looking at the output the issue has something to do with TLS connections timing out. Could perhaps be something as simple as TLS certificates being expired / not valid in future (if the source code has fixed certificates somewhere).

@temeo
Copy link
Contributor

temeo commented Oct 2, 2023

The probable reason for test failures is indeed certificates which expire in Jan 6 10:30:06 2024 GMT,
the build system current time is Wed Oct 23 08:57:16 +14 2024.

So the tests which require certificates need to be fixed to generate the certificates automatically.

@temeo
Copy link
Contributor

temeo commented Jan 15, 2024

Fixed in Galera 26.4.17.

@ottok
Copy link
Contributor Author

ottok commented May 5, 2024

For the record, latest Galera 26.4.18 in Debian builds pass on all reproducible build builders.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants