New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: new directory input validation #3233

Merged

SaraVieira merged 1 commit into codesandbox:master from jyash97:fix/new-directory-validation

Jan 2, 2020

Contributor

jyash97 commented Dec 21, 2019

What kind of change does this PR introduce?

Bug Fix

What is the current behavior?

Chrome autocomplete shows up
Typing a or A gives an error
Added more special characters ( Not sure if it is needed )
On putting, whitespaces error is not shown

What is the new behavior?

Disable chrome autocomplete
Fixed regex for special characters
Whitespace checks

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

Tested locally by checking all condition

Checklist

Testing
Ready to be merged
Added myself to contributors table


          fix: new directory input validation

3eab59c

lbogdan deployed to pr3233

December 21, 2019 07:07

View deployment

Contributor

lbogdan commented Dec 21, 2019

Build for latest commit 3eab59c is at https://pr3233.build.csb.dev/s/new.

SaraVieira approved these changes

View reviewed changes

Contributor

SaraVieira left a comment

Thank you so much! Much better UI

SaraVieira merged commit 0208bd6 into codesandbox:master

Contributor Author

jyash97 commented Jan 2, 2020

Hey, thanks for the review 👍 Glad this PR helped :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet