Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Button #3301

Merged
merged 4 commits into from
Jan 10, 2020
Merged

Components: Button #3301

merged 4 commits into from
Jan 10, 2020

Conversation

siddharthkp
Copy link
Contributor

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. Step A
  2. Step B
  3. Step C

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@lbogdan lbogdan temporarily deployed to pr3301 January 9, 2020 12:48 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Jan 9, 2020

Build for latest commit fe3131e is at https://pr3301.build.csb.dev/s/new.

@lbogdan lbogdan temporarily deployed to pr3301 January 9, 2020 14:18 Inactive
@@ -34,6 +34,11 @@ const theme = {
},

shadows: {
// based on elevation levels
0: 'none',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!

@SaraVieira SaraVieira merged commit 41d9803 into master Jan 10, 2020
@SaraVieira SaraVieira deleted the components-button branch January 10, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants