Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add template copy link #3936

Merged
merged 1 commit into from
Apr 18, 2020

Conversation

jyash97
Copy link
Contributor

@jyash97 jyash97 commented Apr 18, 2020

What kind of change does this PR introduce?

Feature 🌈

What is the current behavior?

Currently, we don't have a copy link option in the context menu

What is the new behavior?

Add option to copy link

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. Locally verified the copied link

Checklist

  • Testing
  • Ready to be merged
  • Added myself to contributors table

@lbogdan
Copy link
Contributor

lbogdan commented Apr 18, 2020

Build for latest commit 8d41d1e is at https://pr3936.build.csb.dev/s/new.

@@ -404,7 +404,7 @@ class SandboxItemComponent extends React.PureComponent<Props, State> {

copySandboxURL = () => {
const url = sandboxUrl({ id: this.props.id, alias: this.props.alias });

// TODO: Use effects.browse.copyToClipboard after refactoring to Function Component
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you so much!

@SaraVieira SaraVieira merged commit 301efc5 into codesandbox:master Apr 18, 2020
@jyash97
Copy link
Contributor Author

jyash97 commented Apr 18, 2020

Thanks for the quick review. 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants