Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto-join workspace after sign-up #8432

Merged
merged 6 commits into from
Apr 30, 2024
Merged

feat: auto-join workspace after sign-up #8432

merged 6 commits into from
Apr 30, 2024

Conversation

danilowoz
Copy link
Member

@danilowoz danilowoz commented Apr 24, 2024

Screenshot 2024-04-26 at 08 43 15

Closes PC-1806

Copy link

codesandbox bot commented Apr 24, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

linear bot commented Apr 24, 2024

@danilowoz danilowoz marked this pull request as ready for review April 26, 2024 07:44
@danilowoz danilowoz changed the title Auto-join workspace feat: auto-join workspace after sign-up Apr 26, 2024
Copy link
Contributor

@christianalfoni christianalfoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking that we should disable the "next" button while it is figuring out eligible workspace to join? There can be latency and it feels a bit weird that it starts enabled and then suddenly becomes disabled. Is there a loading indicator while it is figuring out eligible workspace?

@danilowoz danilowoz merged commit 0c94247 into master Apr 30, 2024
12 of 15 checks passed
@danilowoz danilowoz deleted the ws/auto-join branch April 30, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants