Skip to content

Commit

Permalink
chore: 불필요한 코드 삭제
Browse files Browse the repository at this point in the history
- VMAction, VMState에 선언된 accept, bind 메소드 삭제
  (해당 로직은 VM이 구현해도 되고 안해도 되므로)
- ImageManger 로직에 들어간 print문 삭제

jeremy0405/airbnb/#9
  • Loading branch information
sanghyeok-kim committed May 30, 2022
1 parent 4094530 commit b773fb7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,7 @@ import Foundation

protocol SearchHomeViewModelAction {
var loadHeader: PublishRelay<Void> { get }
var loadImage: PublishRelay<Void> { get }
var loadCityName: PublishRelay<Void> { get }
var loadNearCities: PublishRelay<Void> { get }
var loadHeroBanner: PublishRelay<Void> { get }
var loadTheme: PublishRelay<Void> { get }

func acceptHeader(value: Void)
func acceptImage(value: Void)
func acceptCityName(value: Void)
func acceptTheme(value: Void)
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,7 @@ import Foundation

protocol SearchHomeViewModelState {
var loadedHeader: PublishRelay<[String]> { get }
var loadedImage: PublishRelay<String> { get }
var loadedCityName: PublishRelay<[String]> { get }
var loadedNearCities: PublishRelay<[SearchHomeEntity.City]> { get }
var loadedHeroBanner: PublishRelay<[SearchHomeEntity.Banner]> { get }
var loadedTheme: PublishRelay<[String]> { get }

func bindHeader(completion: @escaping ([String]) -> Void)
func bindImage(completion: @escaping (String) -> Void)
func bindCityName(completion: @escaping ([String]) -> Void)
func bindTheme(completion: @escaping ([String]) -> Void)
}
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ class ImageManager {
let destination = cachesDirectory.appendingPathComponent(fileName)

if fileManager.fileExists(atPath: destination.path) {
print("Cache Hit")
let image = UIImage(contentsOfFile: destination.path)
completion(image)
return
Expand Down

0 comments on commit b773fb7

Please sign in to comment.