-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Team 14] 메인 탭에서 검색 바를 터치하면 여행지 추천 및 검색 화면으로 이동 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[iOS] 처음 앱을 실행하면 홈 화면으로 들어가고 3개의 탭바를 볼 수 있음
�[iOS] ViewController가 여행지 추천을 요청하면 Dummy 데이터를 받을 수 있음
[iOS] 검색바를 터치하면 검색용 화면으로 이동할 수 있음 #6
ocipap
pushed a commit
that referenced
this pull request
May 26, 2022
* Update issue templates * PR template update * Update README.md * chore: readme 파일 수정 * env: 개발 환경 설정 구성(#3) Co-authored-by: Hemudi <hemudi@users.noreply.github.com> * chore: 불필요한 파일 삭제(#3) Co-authored-by: Hemudi <hemudi@users.noreply.github.com> Co-authored-by: Deok Yun Kim <59705184+dukcode@users.noreply.github.com> Co-authored-by: dlwnstjrzz <95525638+dlwnstjrzz@users.noreply.github.com> Co-authored-by: Hemudi <hemudi@users.noreply.github.com>
sabgilhun
pushed a commit
that referenced
this pull request
May 26, 2022
[Android] 히데& 라이너스 스타일 테마 정의
choichoigang
pushed a commit
that referenced
this pull request
May 26, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
SearchViewController에서 SearchBar를 구현하도록 변경
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
SangHwi-Back
pushed a commit
that referenced
this pull request
May 27, 2022
SangHwi-Back
pushed a commit
that referenced
this pull request
May 27, 2022
SangHwi-Back
pushed a commit
that referenced
this pull request
May 27, 2022
SangHwi-Back
pushed a commit
that referenced
this pull request
May 27, 2022
[#3] fix: Tab 별 이미지와 색상을 요구사항에 맞게 수정
jminie-o8o
added a commit
that referenced
this pull request
May 27, 2022
navigation component 로 화면 구성
junseokseo9306
pushed a commit
that referenced
this pull request
May 27, 2022
edittext에 밑 줄을 없애기 위해 background를 transparent로 하게되면 커서가 사라지므로 따로 drawable로 생성
junseokseo9306
pushed a commit
that referenced
this pull request
May 27, 2022
junseokseo9306
pushed a commit
that referenced
this pull request
May 27, 2022
ocipap
pushed a commit
that referenced
this pull request
May 30, 2022
* Update issue templates * PR template update * Update README.md * chore: readme 파일 수정 * env: 개발 환경 설정 구성(#3) Co-authored-by: Hemudi <hemudi@users.noreply.github.com> * chore: 불필요한 파일 삭제(#3) Co-authored-by: Hemudi <hemudi@users.noreply.github.com> * env: Typescript 절대경로 설정 Co-authored-by: jimmy neutron <dlwnstjrzz@users.noreply.github.com> * Design: GlobalStyle, Default Theme 적용 Co-authored-by: jimmy neutron <dlwnstjrzz@users.noreply.github.com> * feat: Icon 컴포넌트 구현 & hero img 업로드 Co-authored-by: jimmy neutron <dlwnstjrzz@users.noreply.github.com> * feat: menubar 컴포넌트 구현 Co-authored-by: jimmy neutron <dlwnstjrzz@users.noreply.github.com> * feat: loginMenu 컴포넌트 구현 Co-authored-by: jimmy neutron <dlwnstjrzz@users.noreply.github.com> * feat: gnb 컴포넌트 구현 Co-authored-by: jimmy neutron <dlwnstjrzz@users.noreply.github.com> * feat: SearchBarItem 컴포넌트 구현 * feat: searchBar 컴포넌트 구현 Co-authored-by: jimmy neutron <dlwnstjrzz@users.noreply.github.com> * feat: header 컴포넌트 구현 Co-authored-by: jimmy neutron <dlwnstjrzz@users.noreply.github.com> Co-authored-by: Deok Yun Kim <59705184+dukcode@users.noreply.github.com> Co-authored-by: dlwnstjrzz <95525638+dlwnstjrzz@users.noreply.github.com> Co-authored-by: Hemudi <hemudi@users.noreply.github.com> Co-authored-by: jimmy neutron <dlwnstjrzz@users.noreply.github.com>
tmdgusya
added a commit
that referenced
this pull request
Jun 4, 2022
[Team-24][BE] airbnb 프로젝트 PR #3
CMSSKKK
added a commit
that referenced
this pull request
Jun 6, 2022
[team-14 BE] airbnb 프로젝트 2주차 1번째 PR 입니다. #3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot
작업 목록
고민과 해결
📌 주변 여행지 추천을 하기 위해서는 초기 화면에서부터 위치가 필요합니다.
CLLocationManager
를 이용하여 아예 초기에 위치 권한을 요청해서 받아오도록 했습니다.📌 그러나 위치 업데이트를 너무 자주하지 않도록 만들 필요가 있었습니다.
📌 위치/장소를 표현하는 도메인 모델이 필요했습니다.
📌 백엔드가 완성되지 않았기에 가짜로 응답 데이터를 만들어야 했습니다.
📌 NavigationController로 다음 화면으로 이동 후, 돌아왔을 때 전체가 비활성화 되는 문제가 있었습니다.
📌 searchBar가 navigationController item과 같이 보여져야하는데 아예 대체해버리는 문제가 있었습니다.