-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE][Team23] 첫 번째 PR - 요구사항 분석 & 컴포넌트 설계 #6
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cf1d6c5
[#2] Init: Update issue templates
jaypedia 9b393bb
[#2] Init: Update README.md
jaypedia 9b557e3
[#2] Init: Update issue templates
jaypedia aee09eb
[#2] Init: Pull Request Template 추가
jaypedia ea380f9
[#2] Init: issue label 추가
jaypedia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
--- | ||
name: Feature request | ||
about: Suggest an idea for this project | ||
title: '' | ||
labels: '' | ||
assignees: '' | ||
|
||
--- | ||
|
||
# Description | ||
|
||
# Progress | ||
- [ ] todo |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
## 1. 구현 결과 | ||
- 데모 사이트 or GIF | ||
|
||
## 2. 구현 내역 | ||
- [x] | ||
|
||
## 3. 고민 & 질문 | ||
|
||
## 4. 이후 계획 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,90 @@ | ||
# airbnb | ||
그룹 프로젝트 #4 | ||
# Airbnb Project | ||
|
||
## 😀 Team members | ||
|
||
### **Front-End** | ||
|
||
[Millie](https://github.com/jaypedia) | ||
[Oliver](https://github.com/jthw1005) | ||
|
||
### **Back-End** | ||
[땃쥐](https://github.com/ttasjwi) | ||
|
||
</br> | ||
|
||
## **🛠 Tools** | ||
|
||
### **Front-End :** | ||
|
||
<img src="https://img.shields.io/badge/HTML5-E34F26?style=flat-square&logo=HTML5&logoColor=white"/> <img src="https://img.shields.io/badge/CSS3-1572B6?style=flat-square&logo=CSS3&logoColor=white"/> <img src="https://img.shields.io/badge/Styled Components-DB7093?style=flat-square&logo=styled-components&logoColor=white"/> <img src="https://img.shields.io/badge/TypeScript-2E508F?style=flat-square&logo=TypeScript&logoColor=white"/> <img src="https://img.shields.io/badge/React-61DAFB?style=flat-square&logo=React&logoColor=white"/> <img src="https://img.shields.io/badge/VSC-007ACC?style=flat-square&logo=VisualStudioCode&logoColor=white"/> <img src="https://img.shields.io/badge/Webpack-76C0FE?style=flat-square&logo=Webpack&logoColor=white"/> <img src="https://img.shields.io/badge/Storybook-FF4785?style=flat-square&logo=Storybook&logoColor=white"/> <img src="https://img.shields.io/badge/MUI-62B000?style=flat-square&logo=mui&logoColor=white"/> | ||
|
||
### **Back-End :** | ||
|
||
<img src="https://img.shields.io/badge/Java-007396?style=flat-square&logo=Java&logoColor=white"/> <img src="https://img.shields.io/badge/Intellij-000000?style=flat-square&logo=IntellijIDEA&logoColor=white"/> <img src="https://img.shields.io/badge/SpringBoot-6DB33F?style=flat-square&logo=SpringBoot&logoColor=white"/> <img src="https://img.shields.io/badge/MySQL-4479A1?style=flat-square&logo=MySQL&logoColor=white"/> <img src="https://img.shields.io/badge/AWS-232F3E?style=flat-square&logo=AmazonAWS&logoColor=white"/> <img src="https://img.shields.io/badge/NGINX-009639?style=flat-square&logo=NGINX&logoColor=white"/> | ||
|
||
</br> | ||
|
||
## 🔥 Ground Rule | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ground Rule 구체적이네요. 좋습니다. |
||
- 데일리 스크럼은 10:00~10:30 AM 동안 진행 | ||
- 멤버들이 돌아가며 데일리 스크럼 사회자를 맡고 그 날의 사회자가 노션, Wiki 정리를 맡음 | ||
- 활동 시간은 최소 50분 ~ 최대 90분이며 활동 후 10분 쉬는 시간 | ||
- 리뷰는 5:30~6:00 PM 동안 진행 | ||
- 일일 회고 & 주간 회고는 노션/Wiki에 오후 11시까지 작성 | ||
- 마일스톤은 PR별로 생성 : 매주 수, 금요일 | ||
|
||
</br> | ||
|
||
## 🌈 Branch 전략 | ||
- team-23: 마스터 브랜치, PR 리뷰 이후 머지되는 브랜치 | ||
- dev-BE: BE 디폴트 브랜치 | ||
- dev-FE: FE 디폴트 브랜치 | ||
- feature: 기능개발 브랜치 | ||
- PR마다 태그를 달아서 버전 명시하기 | ||
|
||
|
||
</br> | ||
|
||
## 📝 Convention | ||
|
||
### 📌 Commit | ||
|
||
``` | ||
[#이슈번호] Type: 커밋 제목 | ||
|
||
커밋에 대한 설명 | ||
``` | ||
|
||
| Type | Description | | ||
| ---------------- | ------------------------------------------------------------------------------------------------- | | ||
| Init | 초기화 | | ||
| Feat | 새로운 기능 추가 | | ||
| Fix | 버그 수정 | | ||
| Docs | 문서 작업, 수정 | | ||
| Refactor | 코드 리팩토링 | | ||
| Style | 코드 스타일 및 포맷 변경(코드 자체의 변경은 없는 경우, 함수/ 변수명 변경 포함) | | ||
| Test | 테스트 코드 작성, 테스트 리팩토링(프로덕션 코드 변경 X) | | ||
| Chore | 소스 코드를 건들지 않는 작업 - 빌드 테스트 업데이트, 패키지 매니저를 설정하는 경우(ex: gitignore) | | ||
| Design | CSS 등 UI 디자인 변경 | | ||
| Ci | CI 관련 설정 수정 | | ||
| Rename | 파일 혹은 폴더명을 수정하거나 옮기는 작업만 수행 | | ||
| Remove | 파일을 삭제하는 작업만 수행 | | ||
| Comment | 필요한 주석 추가 및 변경 | | ||
| Build | 빌드 관련 파일 수정 | | ||
| !BREAKING CHANGE | 커다란 API 변경 | | ||
| !HOTFIX | 급하게 치명적인 버그를 고쳐야 하는 경우 | | ||
|
||
### 📌 Issue Template | ||
|
||
``` | ||
## Description | ||
작업 설명 | ||
|
||
## Progress | ||
- [ ] Task | ||
``` | ||
|
||
</br> | ||
|
||
## 🗂 Wiki | ||
|
||
- [프로젝트 회고](https://github.com/jaypedia/airbnb/wiki/%ED%94%84%EB%A1%9C%EC%A0%9D%ED%8A%B8-1%EC%A3%BC%EC%B0%A8-%ED%9A%8C%EA%B3%A0(2022.5.23~5.27)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
[ | ||
{ | ||
"name": "⚙ Setting", | ||
"color": "e3dede", | ||
"description": "개발 환경 세팅" | ||
}, | ||
{ | ||
"name": "✨ Feature", | ||
"color": "a2eeef", | ||
"description": "기능 개발" | ||
}, | ||
{ | ||
"name": "🌏 Deploy", | ||
"color": "C2E0C6", | ||
"description": "배포 관련" | ||
}, | ||
{ | ||
"name": "🎨 Design", | ||
"color": "FEF2C0", | ||
"description": "Styling" | ||
}, | ||
{ | ||
"name": "🐞 BugFix", | ||
"color": "d73a4a", | ||
"description": "Something isn't working" | ||
}, | ||
{ | ||
"name": "💻 CrossBrowsing", | ||
"color": "C5DEF5", | ||
"description": "브라우저 호환성" | ||
}, | ||
{ | ||
"name": "📃 Docs", | ||
"color": "1D76DB", | ||
"description": "문서 작성 및 수정 (README.md 등)" | ||
}, | ||
{ | ||
"name": "📬 API", | ||
"color": "D4C5F9", | ||
"description": "서버 API 통신" | ||
}, | ||
{ | ||
"name": "🔨 Refactor", | ||
"color": "f29a4e", | ||
"description": "코드 리팩토링" | ||
}, | ||
{ | ||
"name": "🙋♂️ Question", | ||
"color": "9ED447", | ||
"description": "Further information is requested" | ||
}, | ||
{ | ||
"name": "🥰 Accessibility", | ||
"color": "facfcf", | ||
"description": "웹접근성 관련" | ||
}, | ||
{ | ||
"name": "✅ Test", | ||
"color": "ccffc4", | ||
"description": "test 관련(storybook, jest...)" | ||
}, | ||
{ | ||
"name": "BE", | ||
"color": "000000", | ||
"description": "Backed label" | ||
}, | ||
{ | ||
"name": "FE", | ||
"color": "ffffff", | ||
"description": "Frontend label" | ||
} | ||
] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ISSUE, PR template 좋네요ㅎㅎ