-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] overriding multiples arguments; #60
Comments
@qschmick would you like to take a look at this. I would appreciate it. |
@roshangautam Sure thing. @JeanCarloLeal Can you add the |
@qschmick I have not tested creating my command with --options, I believe this works. But using multiple arguments we've found the problem quoted. |
@JeanCarloLeal thanks for the follow up. For clarification, you are passing the values |
In totem Usage: seaport=15 typeTraffic=05 |
@JeanCarloLeal Just merged in a fix for this issue. |
Ty |
@qschmick I was updating my project and had a surprise, I'm using v2.1. And your fix was for v2.0, can you check?
|
Its probably because its not been tagged yet. |
@JeanCarloLeal Just tagged v2.2 |
Creating at new task: in the field "PARAMETERS (OPTIONAL)" I insert the following information for a custom command that can accept multiple arguments: "seaport=15 typetraffic=05"
When i click Execute (to force execution) it works, because it don't use the console. However, when using the console (Laravel's schedule), it errors.
I took the liberty to debug the code and found a problem in the file Task.php, method compileParameters.
The problem happens because when running on console it doesn't pass named parameters, and in the mentioned method it will override the first parameter with the second as both will have the key 0.
Following is a Print of a fix.
Please inform me if there is another solution.
The text was updated successfully, but these errors were encountered: