-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D3 v4 and reducing bundle size #133
Comments
Hey, thank you! Have you considered tree shaking? I didn't check yet in my projects but reading about it, it should be helpful in your case. I just checked out the d3 v4 change log and there is a lot of stuff going on. Sorry I couldn't give you any good news! |
Yes indeed tree shaking would be a perfect solution. Only it currently works with libraries using es2015 imports, which d3 isn't. I'll have a look later on this weekend see what's required to move to v4 (like you said, lots of changes) |
Yo, Where the stack layout used to send back your dataset with Now, I'm not very familiar with d3 and I don't use stack (very simple graph I make :P), so I didn't go further than fixing namespace. My AreaChart works nicely using d3v4 so far. I still think it's doable and definitely worth trying since d3 v4 seems to be awesome. |
@PierreGUI I work on migration, and I just need help with the method |
Oh man that was a year ago... I'm afraid I won't be of much help. Cheers Edit: afaiu new d3 stack sends back a matrix with one line per series and column contains the (y0, y) values corresponding. Looking at example on the official doc, it now looks like this I'm wondering about your mixins, will you move away from it now that they are deprecated? |
Yes i know about the problem the following commit will just help rid of myxins. #120 |
Hey there,
Thanks for amazing work!
I'm showing one tiny graph on my page and d3 is now my biggest dependency (appart from react).
Even for minimal use, importing the whole d3 v3.5 is necessary...
Any plan on moving to d3 v4?
That'd be awesome (even though I'm not sure how much work is necessary (: )
The text was updated successfully, but these errors were encountered: