Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to 5 version D3 #156

Closed
wants to merge 12 commits into from
Closed

Migration to 5 version D3 #156

wants to merge 12 commits into from

Conversation

retyui
Copy link
Contributor

@retyui retyui commented May 25, 2018

Remove .npmignore used package.json -> files (check result npm pack)
Update D3 version to latest
Did the formatting eslint --fix

Eslint formater
@retyui
Copy link
Contributor Author

retyui commented May 25, 2018

#155

@codesuki
Copy link
Owner

That was quick! Thanks for the PR. Please let me check it on monday, I am away for the weekend. Thanks again!

@retyui
Copy link
Contributor Author

retyui commented May 25, 2018

replace schemeCategory20 => schemeCategory10

D3 no longer provides the d3.schemeCategory20* categorical color schemes

@retyui
Copy link
Contributor Author

retyui commented May 26, 2018

There are still many problems, I now understand what this method does

https://github.com/codesuki/react-d3-components/blob/master/src/StackDataMixin.jsx#L26-L52

@codesuki
Copy link
Owner

Is this PR still WIP?
If you need me to explain any part of the code, let me know!

@retyui
Copy link
Contributor Author

retyui commented May 28, 2018

@codesuki Yes, this PR still work in progress.
In the near future I will try to end the migration

@retyui
Copy link
Contributor Author

retyui commented May 29, 2018

@codesuki
I almost finished left the most difficult for me : this is a change for d3.stack StackDataMixin.jsx#L27-L39
mentioned by @PierreGUI #133 (comment)

Fast check result

git clone https://github.com/retyui/react-d3-components -b d3-version-5
yarn
yarn watch

And open: http://localhost:3000/example/d3-v5/

@codesuki
Copy link
Owner

Great! I'll have a look later today. Thanks!

@retyui
Copy link
Contributor Author

retyui commented May 30, 2018

@codesuki Well, what do you say?

@codesuki
Copy link
Owner

codesuki commented Jun 6, 2018

Sorry, in the middle of release preparations. I'll need a few more days until I have time to check it out.

@retyui retyui closed this Jun 6, 2018
@codesuki
Copy link
Owner

codesuki commented Jun 6, 2018

What happened?

@retyui
Copy link
Contributor Author

retyui commented Jun 6, 2018

Do not worry, I want to do everything in stages. Multiple steps for migration

@retyui
Copy link
Contributor Author

retyui commented Jun 7, 2018

@codesuki
This is a list of changes that need to be made so that migration is as productive as possible:

  1. Add lint-staged, prettier, update webpack to latest version
  2. Add test for components
  3. Replace mixins to hocs
  4. Migrate to d3 version 5
    Do you agree with these changes?

@codesuki
Copy link
Owner

codesuki commented Jun 8, 2018

Yes that is a reasonable list. Step 3 is mostly useful for React upgrades, but super useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants