-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to 5 version D3 #156
Conversation
Eslint formater
That was quick! Thanks for the PR. Please let me check it on monday, I am away for the weekend. Thanks again! |
replace
|
There are still many problems, I now understand what this method does https://github.com/codesuki/react-d3-components/blob/master/src/StackDataMixin.jsx#L26-L52 |
Is this PR still WIP? |
@codesuki Yes, this PR still work in progress. |
@codesuki Fast check result
And open: http://localhost:3000/example/d3-v5/ |
Great! I'll have a look later today. Thanks! |
@codesuki Well, what do you say? |
Sorry, in the middle of release preparations. I'll need a few more days until I have time to check it out. |
What happened? |
Do not worry, I want to do everything in stages. Multiple steps for migration |
@codesuki
|
Yes that is a reasonable list. Step 3 is mostly useful for React upgrades, but super useful. |
Remove .npmignore used
package.json -> files
(check resultnpm pack
)Update D3 version to latest
Did the formatting
eslint --fix