fix verification testing

auctions/models.py

@@ -259,7 +259,6 @@ def payout(self):
                     discount=discount_amount
                 )
                 new_offer.save()
-
                 # capture payment to this users account
                 payout = Payout(
                     user=offer.user,

payments/models.py

@@ -40,7 +40,6 @@ def identity_verified(self):
         else:
             # returning True will allow the bank account_id to be assigned
             return True
-
         if not self.verification:
             return True
         else:

payments/tests/__init__.py

@@ -3,45 +3,53 @@
 
 
 def setUpPackage(self):
+    # mock stripe Customer
     mock_id = fudge.Fake().has_attr(id='dammit')
-    mock_ext_acct = (
-        fudge.Fake().has_attr(external_account='').provides('save').is_a_stub()
-    )
-
     mock_customer = (
         fudge.Fake().provides('create').returns(mock_id)
     )
     self.patch_stripe = fudge.patch_object(
         'payments.utils.stripe', 'Customer', mock_customer)
 
-    mock_keys = {"id": "acct_12QkqYGSOD4VcegJ",
-                 "keys": {"secret": "sk_live_AxSI9q6ieYWjGIeRbURf6EG0",
-                          "publishable": "pk_live_h9xguYGf2GcfytemKs5tHrtg"
-                          }}
-
-    mock_account = (
-        fudge.Fake().provides('create').returns(mock_keys)
-        .provides('retrieve').returns(mock_ext_acct)
-    )
-
-    self.patch_stripe = fudge.patch_object(
-        'payments.utils.stripe', 'Account', mock_account)
-
+    # mock stripe Event
     evt_resp = json.loads(payment_created)
-
     mock_event = (
         fudge.Fake().provides('retrieve').has_attr(verified=True)
         .returns(evt_resp)
     )
-
     self.patch_stripe = fudge.patch_object(
         'payments.utils.stripe', 'Event', mock_event)
 
+    # mock stripe account_id
+    setup_mock_account(verification=account_verified)
+
 
 def tearDownPackage(self):
     self.patch_stripe.restore()
 
 
+def setup_mock_account(verification):
+    account_id = 'acct_12QkqYGSOD4VcegJ'
+    mock_ext_acct = (
+        fudge.Fake().has_attr(external_account='')
+                    .provides('save').is_a_stub()
+    )
+    mock_ext_acct.has_attr(id=account_id)
+    mock_ext_acct.has_attr(verification=json.loads(verification))
+
+    mock_keys = {"id": account_id,
+                 "keys": {"secret": "sk_live_AxSI9q6ieYWjGIeRbURf6EG0",
+                          "publishable": "pk_live_h9xguYGf2GcfytemKs5tHrtg"}}
+
+    mock_account = (
+        fudge.Fake().provides('create').returns(mock_keys)
+        .provides('retrieve').returns(mock_ext_acct)
+    )
+
+    fudge.patch_object(
+        'payments.utils.stripe', 'Account', mock_account)
+
+
 # test constants below:
 account_verified = """
 {
@@ -54,7 +62,7 @@ def tearDownPackage(self):
 
 account_not_verified = """
 {
-    "due_by": "null",
+    "due_by": "123",
     "fields_needed": [
         "legal_entity.first_name",
         "legal_entity.last_name"

payments/tests/model_tests.py

@@ -11,7 +11,7 @@
 
 from . import (
     application_fee_created, balance_available, account_verified,
-    account_not_verified, payment_created, account_updated
+    account_not_verified, payment_created, account_updated, setup_mock_account
 )
 
 
@@ -38,12 +38,14 @@ def test_identity_verified(self):
         # new accounts should pass
         self.assertTrue(account.identity_verified())
 
+        account.account_id = "something"
+
         # test valid verification
-        account.verification = account_verified
+        setup_mock_account(verification=account_verified)
         self.assertTrue(account.identity_verified())
 
         # test invalid verification
-        account.verification = account_not_verified
+        setup_mock_account(verification=account_not_verified)
         self.assertFalse(account.identity_verified())
 
     def test_fields_needed(self):

payments/utils.py

@@ -84,6 +84,7 @@ def refund(offer):
         )
         if refund:
             offer.refund_id = refund.id
+            offer.save()
     except Exception as e:
         print e.message
         offer.error_message = e.message