New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django sass process 622 #629
Conversation
@@ -11,7 +12,7 @@ | |||
<link rel="shortcut icon" href="{% static "img/favicon.png" %}"> | |||
<link rel="stylesheet" href="https://cdn.jsdelivr.net/foundation/6.2.4/foundation.min.css"> | |||
<link rel="stylesheet" href="https://cdn.jsdelivr.net/foundation-icons/3.0/foundation-icons.min.css"> | |||
<link rel="stylesheet" href="{% static "css/codesy-home.css" %}"> | |||
<link rel="stylesheet" href="{% sass_src "css/scss/codesy-home.scss" %}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sass_src
automatically converts this to look for the compiled .css
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the development process when you're working on local changes with the Django tool? Do we still leave the README the same for now, or reference the offline compile option from the Django-sass-processor documentation?
As I understand it, This PR also adds a new |
10-4. This is good by me! |
I'm happy to wait on this, but I wanted to put it up here for consideration ...
This includes #625 and adds
django-sass-processor
so we can just keep.scss
files in the repo, and letdjango-sass-processor
compile the.css
files during deployment release.The alternative to this is either:
.css
files into the repo and hope we don't forget them each time.scss
files into.css
with Rubysass
command