Added the 404 component #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for donut-frontend-r ready! Built with commit 3c96599 |
elit-altum
force-pushed
the
404-Component
branch
from
9c48f83
to
acc48be
Compare
|
@devesh-verma can you take a look once. Thanks |
| @@ -15,6 +16,7 @@ const Router = () => ( | |||
| <Route exact path="/pinned-posts" component={PinnedPosts} /> | |||
| <Route exact path="/profile" component={Profile} /> | |||
| <Route exact path="/organization" component={Organization} /> | |||
| <Route component={NotFound} /> | |||
There was a problem hiding this comment.
path is missing for not found route that is 404
There was a problem hiding this comment.
Sir no specific path is required there. The component 'NotFound' will render at every path not already specified above it. Therefore showing a 404 error for every route which is not specified in the app, and the user tries to access it.
There was a problem hiding this comment.
so usually, I have seen route as * for 404, please let me know if its not needed so that I can merge.
|
@elit-altum can please resolve the merge conflict and update the PR. |
elit-altum
force-pushed
the
404-Component
branch
2 times, most recently
from
085d3ac
to
d331739
Compare
elit-altum
force-pushed
the
404-Component
branch
from
47d01c1
to
f7cce11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a newly designed 404 page for handling unspecified routes.
Fixes #275