Skip to content

Commit

Permalink
Test workflow improvements
Browse files Browse the repository at this point in the history
- document the Rubies we are using for tests
- document the need for `bundler` gem
- commit `package-lock.json` file for reproducible tests
- switch to Poltergeist for headless tests
- test for existence of socket file
- ease the requirement for tempfile location
  • Loading branch information
tilsammans committed Jul 25, 2017
1 parent 60713f6 commit 60b0f27
Show file tree
Hide file tree
Showing 7 changed files with 8,486 additions and 9 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ Pageflow assumes the following choice of libraries:

Pageflow runs in environments with:

* Ruby >= 2.1
* Ruby >= 2.1 (see `.travis.yml` for supported versions)
* Node >= 6.9.5
* Rails 4.2
* Redis server (for Resque)
Expand Down
3 changes: 2 additions & 1 deletion doc/contributing/rails_engine_development.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@
Ensure the development machine meets the requirements listed in the
readme. From the repository root run:

$ gem install bundler
$ bundle install
$ bin/npm install

Build node package to `assets` directory:

$ bin/npm run build
Expand Down
Loading

0 comments on commit 60b0f27

Please sign in to comment.