Audio API #319
Merged
Audio API #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract functionality from audio page type: * Bind audio volume to pageflow settings while playing * Add methods to fade audio player in and our.
Move creation of slidehsow related globals to a single place. Allow reuse in editor.
Provide factory method for audio players from audio file ids. Inside the editor, retrieve sources from Backbone models. For published entries, provide sources via json seed.
Add factory method to audio API to create a player object which orchestrates many audio players. This allows to fade between different audio files.
Prevent conflict with audio page features until audio page also uses audio API.
Reuse for video player.
Call functions before snd after playback. Allow delaying playback by returning a promise.
Allow to add a suffix to audio ids. This makes is possible to use the same audio file multiple times inside a pool.
Use for playing from beginning in multi player.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract audio related functionality from page types into
pageflow.audiomodule.