Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark %pageflow_widget_margin_right optional #773

Merged
merged 1 commit into from
May 26, 2017
Merged

mark %pageflow_widget_margin_right optional #773

merged 1 commit into from
May 26, 2017

Conversation

tilsammans
Copy link
Contributor

widgets don't have to provide it.
it will raise an error in the default player otherwise.

continuation of #771

@tilsammans
mark %pageflow_widget_margin_right optional
bf1b3cf 
widgets don't _have_ to provide it.
it will raise an error in the default player otherwise.

continuation of #771
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.032% when pulling bf1b3cf on scrollytelling:pageflow-widget-margin-right-optional into 44b9d85 on codevise:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.032% when pulling bf1b3cf on scrollytelling:pageflow-widget-margin-right-optional into 44b9d85 on codevise:master.

@tf tf added this to the v12.0 milestone May 26, 2017
@tf tf merged commit b452c34 into codevise:master May 26, 2017
@tilsammans tilsammans deleted the pageflow-widget-margin-right-optional branch May 26, 2017 10:22
@tf tf added the bug label May 30, 2017
tf pushed a commit that referenced this pull request May 31, 2017
@tilsammans @tf
mark %pageflow_widget_margin_right optional
8100a44 
Backport of #773

widgets don't _have_ to provide it.
it will raise an error in the default player otherwise.

continuation of #771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tilsammans @coveralls @tf