Test workflow improvements

.gitignore

@@ -11,3 +11,4 @@ spec/dummy/*
 .idea
 /app/assets/javascripts/pageflow/dist
 .localeapp
+/node_package/package-lock.json

.travis.yml

@@ -19,8 +19,6 @@ services:
 
 before_install:
   - nvm install stable
-  - export DISPLAY=:99.0
-  - sh -e /etc/init.d/xvfb start
 
 before_script:
   - bin/npm install

README.md

@@ -50,7 +50,7 @@ Pageflow assumes the following choice of libraries:
 
 Pageflow runs in environments with:
 
-* Ruby >= 2.1
+* Ruby >= 2.1 (see `.travis.yml` for supported versions)
 * Node >= 6.9.5
 * Rails 4.2
 * Redis server (for Resque)

doc/contributing/rails_engine_development.md

@@ -5,9 +5,10 @@
 Ensure the development machine meets the requirements listed in the
 readme. From the repository root run:
 
+    $ gem install bundler
     $ bundle install
     $ bin/npm install
-    
+
 Build node package to `assets` directory:
 
     $ bin/npm run build

pageflow.gemspec

@@ -128,7 +128,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'capybara', '~> 2.4'
 
   # Headless browser testing
-  s.add_development_dependency 'capybara-webkit', '~> 1.3'
+  s.add_development_dependency 'poltergeist', '~> 1.15.0'
 
   # View abstraction fro integration testing
   s.add_development_dependency 'domino', '~> 0.7.0'

spec/pageflow/paperclip_processors/vtt_spec.rb

@@ -13,7 +13,7 @@ module PaperclipProcessors
 
           file = processor.make
 
-          expect(file.path).to match(/tmp.*\.vtt$/)
+          expect(file.path).to match(/\.vtt\z/)
           expect(file.read).to match(/^WEBVTT/)
         end
       end
@@ -28,7 +28,7 @@ module PaperclipProcessors
 
           file = processor.make
 
-          expect(file.path).to match(/tmp.*\.vtt$/)
+          expect(file.path).to match(/\.vtt\z/)
           expect(file.read).to match(/^WEBVTT/)
         end
       end

spec/support/config/capybara.rb

@@ -1,4 +1,4 @@
 require 'capybara/rspec'
-require 'capybara/webkit'
+require 'capybara/poltergeist'
 
-Capybara.javascript_driver = :webkit
+Capybara.javascript_driver = :poltergeist

spec/support/pageflow/dummy/templates/database.yml

@@ -1,27 +1,25 @@
-development:
+common: &common
   adapter: mysql2
   encoding: utf8
-  database: development
-  pool: 5
   username: <%= ENV.fetch('PAGEFLOW_DB_USER', 'root') %>
   password: <%= ENV.fetch('PAGEFLOW_DB_PASSWORD', '') %>
+  pool: 5
 <% if ENV['PAGEFLOW_DB_HOST'].present? %>
   host: <%= ENV['PAGEFLOW_DB_HOST'] %>
   port: <%= ENV.fetch('PAGEFLOW_DB_PORT', '3306') %>
-<% else %>
+<% elsif File.socket?('/var/run/mysqld/mysqld.sock') %>
   socket: /var/run/mysqld/mysqld.sock
+<% elsif File.socket?('/tmp/mysql.sock') %>
+  socket: /tmp/mysql.sock
+<% else %>
+  host: localhost
+  port: 3306
 <% end %>
 
+development:
+  <<: *common
+  database: development
+
 test:
-  adapter: mysql2
-  encoding: utf8
+  <<: *common
   database: test
-  pool: 5
-  username: <%= ENV.fetch('PAGEFLOW_DB_USER', 'root') %>
-  password: <%= ENV.fetch('PAGEFLOW_DB_PASSWORD', '') %>
-<% if ENV['PAGEFLOW_DB_HOST'].present? %>
-  host: <%= ENV['PAGEFLOW_DB_HOST'] %>
-  port: <%= ENV.fetch('PAGEFLOW_DB_PORT', '3306') %>
-<% else %>
-  socket: /var/run/mysqld/mysqld.sock
-<% end %>