Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve text tracks and info box display logic #826

Merged
merged 9 commits into from
Aug 9, 2017
Merged

Improve text tracks and info box display logic #826

merged 9 commits into from
Aug 9, 2017

Commits on Aug 9, 2017

  1. Improve handling of blank props in info boxes 

    Make sure info box elements are not displayed if the corresponding
props only contain empty strings.
    @tf
    tf committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    5bd7473 View commit details
    Browse the repository at this point in the history

  2. Improve text tracks positioning 

    Move text tracks up immediately when player controls are displayed,
but only move them back down on next cue change when player controls
are hidden again.

When player controls are displayed, we have no other chance than
moving the text tracks directly since they would otherwise be hidden
by the player controls. After the player controls are hidden again, we
can wait for the user to finish reading the current cue and only then
move text tracks back down.
    @tf
    tf committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    dd9f8ab View commit details
    Browse the repository at this point in the history

  3. Add info icon

    @tf
    tf committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    eaed597 View commit details
    Browse the repository at this point in the history

  4. Export isInfoBoxEmpty function from PlayerControls 

    Let other components determine whether an info box will be displayed.
    @tf
    tf committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    4f26c26 View commit details
    Browse the repository at this point in the history

  5. Add props for additional player control buttons 

    Allow passing a custom `className` and mouse enter/mouse leave event
handlers.
    @tf
    tf committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    8b06738 View commit details
    Browse the repository at this point in the history

  6. Rework info box display logic 

    * Add `infoBoxHiddenDuringPlayback` flag to state which can be
  controlled via actions.

* Hide info box directly if text tracks are enabled.

* Remove `has_been_faded` css class which is now unused.
    @tf
    tf committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    7fc019e View commit details
    Browse the repository at this point in the history

  7. Add button to slim player controls to toggle info box

    @tf
    tf committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    d8401d7 View commit details
    Browse the repository at this point in the history

  8. Reset userIsIdle on page change 

    Prevent player controls from fading too quickly after the page has
been entered.
    @tf
    tf committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    bf27ee3 View commit details
    Browse the repository at this point in the history

  9. Require pageflow-public-i18n 1.11

    @tf
    tf committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    4498833 View commit details
    Browse the repository at this point in the history