Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow :create Entry only for publishers on accounts, not on entries #836

Merged
merged 4 commits into from
Aug 28, 2017

Commits on Aug 22, 2017

  1. Fix shared example for membership bases permissions

    Ensure specs for account and entry case can be generated in a single
    invocation of the shared example. Prevent overriding `let` in a loop
    causing only the last case to be used in specs.
    tf committed Aug 22, 2017
    Configuration menu
    Copy the full SHA
    c518af5 View commit details
    Browse the repository at this point in the history
  2. Improve shared example for membership based permissions

    * Fail if unknown option is passed.
    
    * Allow using `of_entry_or_its_account` instead of passing both
      `of_entry` and `of_account` options to make specs more readable.
    
    * Allow testing only the `forbid` case, by aliasing the `but_forbid`
      option and skipping specs for the `allow` case.
    
    * Make spec description generation more DRY.
    tf committed Aug 22, 2017
    Configuration menu
    Copy the full SHA
    574c1e5 View commit details
    Browse the repository at this point in the history
  3. Allow :create Entry only for publishers on accounts, not on entries

    The previous implementation also allowed entry publishers as long as
    they were also publishers of at least one (possibly unrelated)
    account.
    aviav authored and tf committed Aug 22, 2017
    Configuration menu
    Copy the full SHA
    82ac17e View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2017

  1. Configuration menu
    Copy the full SHA
    b130927 View commit details
    Browse the repository at this point in the history