Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #64

Merged
merged 2 commits into from
Aug 10, 2023
Merged

chore: update dependencies #64

merged 2 commits into from
Aug 10, 2023

Conversation

benbierens
Copy link
Contributor

18.16 doesn't work reliably in the dist-test cloud environment. It works fine when the docker image is used on my local machine though. Very annoying.

@AuHau
Copy link
Member

AuHau commented Aug 7, 2023

Have you tried to bump to latest? Would prefer to go forward then backward 😅

@veaceslavdoina
Copy link
Contributor

As I remember I also set node to v18.15.0 in my PR and it was done because of the known issue - hardhat compile randomly and quietly stops before compiling contracts #3877.

Looks like the issue was fixed in Hardaht v2.16.1.

In our package.json we have the following

"hardhat": "^2.12.7",

@dryajov
Copy link
Collaborator

dryajov commented Aug 7, 2023

As I remember I also set node to v18.15.0 in my PR and it was done because of the known issue - hardhat compile randomly and quietly stops before compiling contracts #3877.

Looks like the issue was fixed in Hardaht v2.16.1.

In our package.json we have the following

"hardhat": "^2.12.7",

Seems quite old, we should definitely bump it. Ot does look like it might be the root cause of the failed builds of the multiarch image?

@veaceslavdoina
Copy link
Contributor

It does look like it might be the root cause of the failed builds of the multiarch image?

Oh. sorry about the issue during the Demo :) I've watched it and added some comments.
It was about nim-codex:latest and a temporary tag I've added for Ben to test how can we get the app version 🙄

@veaceslavdoina
Copy link
Contributor

veaceslavdoina commented Aug 8, 2023

And more notes about upgrading node and modules and results in the branch - bumb-hardhat-and-hardhat-deploy

  1. I've updated just some modules
    "hardhat": "^2.17.1",
    "hardhat-deploy": "^0.11.34"
    
  2. I've updated node to the latest LTS release - Node.js 18.17.0 (Hydrogen/2023-07-18)
    node:18.17.0-alpine3.17
  3. Additional modules update fails and should be investigated (for example hardhat-deploy-ethers)
  4. Docker Build was triggered manually and result can be tested
    docker run --rm codexstorage/dist-tests-codex-contracts-eth:sha-d6fbfdc

@veaceslavdoina
Copy link
Contributor

@AuHau added a draft PR and we can consider that only after hardhat-waffle package dependencies update - Ethers v6 support #65.

Now, we should probably go wit the changes proposed above.

@benbierens
Copy link
Contributor Author

codexstorage/dist-tests-codex-contracts-eth:sha-d6fbfdc
Passes test on local instance.
Passes test on cloud instance.

@AuHau
Copy link
Member

AuHau commented Aug 10, 2023

codexstorage/dist-tests-codex-contracts-eth:sha-d6fbfdc
Passes test on local instance.
Passes test on cloud instance.

I am bit confused. Is it with the changes from this PR or from Slava's branch?

Now, we should probably go wit the changes proposed above.

Agree, can you create PR and we can close this one in favor of this new PR?

@veaceslavdoina
Copy link
Contributor

Probably I will commit my changes in Ben's branch. Or it make sense to create a new PR?

@AuHau
Copy link
Member

AuHau commented Aug 10, 2023

Probably I will commit my changes in Ben's branch. Or it make sense to create a new PR?

I don't mind either ;-)

@AuHau AuHau changed the title from 18.16 to 18.15 chore: update dependencies Aug 10, 2023
@AuHau AuHau merged commit ac38d7f into master Aug 10, 2023
5 checks passed
@AuHau AuHau deleted the downbump-node-version branch August 10, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants