Convert from 32 bytes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dryajov
reviewed
Dec 22, 2023
poseidon2/io.nim
Outdated
| let finalChunk = bytes[chunkStart..<bytes.len] & endMarker | ||
| let finalElement = F.fromOpenArray(finalChunk) | ||
| yield finalElement | ||
| if (bytes.len - chunkStart > 0) or empty: |
There was a problem hiding this comment.
I think this was pulled from my padding PR which ended up being the wrong fix. Did something change, or was this pulled in by mistake?
dryajov
force-pushed
the
convert-from-32-bytes
branch
from
1d28cac
to
3b403b0
Compare
emizzle
reviewed
Jan 9, 2024
| @@ -1,5 +1,6 @@ | |||
| import std/unittest | |||
| import std/sequtils | |||
| import std/options | |||
|
Can we get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.