exports fromBytes from the library #19
Merged
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exports
fromBytes
from thenim-poseidon2
lib.It is still a mystery how this is working in
nim-codex/master
:https://github.com/codex-storage/nim-codex/blob/master/codex/merkletree/poseidon2.nim#L77
Before the changes in nim-codex#663,
fromBytes
seemed to have been resolved correctly bynim-poseidon/io
. However, with the changes in nim-codex#663,fromBytes
could no longer be resolved. By exportingfromBytes
fromnim-poseidon2
, the correct resolution is now happening.Note that the base branch for this PR is the branch for #18.