Don't allow to set child element as parent. #19

cabad11 · 2018-12-23T22:19:29Z

Resolves #15

src/routes/pages.js

neSpecc · 2018-12-27T05:57:03Z

src/routes/pages.js

@@ -24,6 +24,18 @@ router.get('/page/edit/:id', async (req, res, next) => {
    let page = await Pages.get(pageId);
    let pagesAvailable = await Pages.getAll();

+    (function childrenRemove(parent) {


нужно оформить в виде нормального метода класса, с понятным названием и документацией.

эта логика не должна быть в роутах. Скорее в модели.

neSpecc · 2018-12-27T05:57:25Z

src/routes/pages.js

@@ -24,6 +24,18 @@ router.get('/page/edit/:id', async (req, res, next) => {
    let page = await Pages.get(pageId);
    let pagesAvailable = await Pages.getAll();

+    (function childrenRemove(parent) {
+      pagesAvailable.forEach((item, index) => {


метод не должен использовать внешние переменные

set function as method of Pages

neSpecc · 2018-12-28T15:09:17Z

src/controllers/pages.js

+  /**
+   * Change wrong pages to null
+   *
+   * @returns {Promise<Page[]>}


она еще true|false возвращает. Надо описать, когда какое значение возвращается и для чего

true false возвращает стрелочная функция а не метод а метод всегда возвращает array

neSpecc · 2018-12-28T15:09:39Z

src/controllers/pages.js

+  static async getWithoutChildren(parent) {
+    let pagesAvailable = this.removeChildren(await Pages.getAll(), parent);
+
+    return pagesAvailable.filter((item) => item !== null);


тут может быть не только array

можно по подробнее
pages.getAll всегда возвращает array

твоя функция возвращает не только array

функция в любом случае возвращает array так как там будет хотя бы сам вызываемый элемент parent

neSpecc · 2018-12-28T15:37:54Z

src/controllers/pages.js

+  static async getWithoutChildren(parent) {
+    let pagesAvailable = this.removeChildren(await Pages.getAll(), parent);
+
+    return pagesAvailable.filter((item) => item !== null);


твоя функция возвращает не только array

neSpecc · 2018-12-28T15:38:08Z

src/controllers/pages.js

+  /**
+   * Change wrong pages to null
+   *
+   * @returns page[]


не правильно задокументированы типы

и не описаны параметры

neSpecc · 2018-12-28T15:38:25Z

src/controllers/pages.js

+  }
+
+  /**
+   * Change wrong pages to null


не понятное описание

neSpecc · 2018-12-28T17:33:51Z

src/controllers/pages.js

+   * @param {string} parent - id of current page
+   * @returns {Promise<Page[]>}
+   */
+  static async getWithoutChildren(parent) {


getAllExceptChildrends

refactor

neSpecc · 2018-12-30T07:43:54Z

src/routes/pages.js

@@ -22,7 +22,7 @@ router.get('/page/edit/:id', async (req, res, next) => {

  try {
    let page = await Pages.get(pageId);
-    let pagesAvailable = await Pages.getAll();
+    let pagesAvailable = await Pages.getAllExceptChildrends(pageId);


Suggested change

let pagesAvailable = await Pages.getAllExceptChildrends(pageId);

let pagesAvailable = await Pages.getAllExceptChildrens(pageId);

src/controllers/pages.js

neSpecc · 2018-12-30T07:44:46Z

src/controllers/pages.js

@@ -41,6 +41,38 @@ class Pages {
    return Model.getAll();
  }

+  /**
+   * @static
+   * Return all pages without children pages


Suggested change

* Return all pages without children pages

* Return all pages without children of passed page

neSpecc · 2018-12-30T07:45:14Z

src/controllers/pages.js

+   * @static
+   * Set all children elements to null
+   *
+   * @param {Array<?Page>} pagesAvailable - Array of all pages


Suggested change

* @param {Array<?Page>} pagesAvailable - Array of all pages

* @param {Page[]} [pagesAvailable] - Array of all pages

Co-Authored-By: cabad11 <44175180+cabad11@users.noreply.github.com>

change comments change metod name

…am/codex.docs into child-element-as-parent

neSpecc · 2019-01-03T11:15:46Z

src/controllers/pages.js

+   * @static
+   * Set all children elements to null
+   *
+   * @param {Page[]} [pagesAvailable] - Array of all pages


разве этот параметр опционален? не нужны квадратные скобки

filter available pages

e61beca

neSpecc requested changes Dec 24, 2018

View reviewed changes

src/routes/pages.js Outdated Show resolved Hide resolved

neSpecc requested changes Dec 27, 2018

View reviewed changes

refactor

e680cd3

set function as method of Pages

neSpecc requested changes Dec 28, 2018

View reviewed changes

change wrong word

bff4dde

neSpecc requested changes Dec 28, 2018

View reviewed changes

change commentaries

a2796f5

neSpecc requested changes Dec 28, 2018

View reviewed changes

cabad11 added 2 commits December 28, 2018 21:37

change method name

5a96e5c

refactor

c053e2a

refactor

neSpecc requested changes Dec 30, 2018

View reviewed changes

neSpecc and others added 3 commits December 30, 2018 12:24

Update src/controllers/pages.js

c1738eb

Co-Authored-By: cabad11 <44175180+cabad11@users.noreply.github.com>

refactor

16810f1

change comments change metod name

Merge branch 'child-element-as-parent' of https://github.com/codex-te…

a543918

…am/codex.docs into child-element-as-parent

neSpecc approved these changes Jan 3, 2019

View reviewed changes

gohabereg approved these changes Jan 3, 2019

View reviewed changes

cabad11 merged commit dbfc594 into master Jan 14, 2019

cabad11 deleted the child-element-as-parent branch January 14, 2019 14:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't allow to set child element as parent. #19

Don't allow to set child element as parent. #19

cabad11 commented Dec 23, 2018

neSpecc Dec 27, 2018

neSpecc Dec 27, 2018

neSpecc Dec 28, 2018

cabad11 Dec 28, 2018 •

edited

Loading

neSpecc Dec 28, 2018

cabad11 Dec 28, 2018

neSpecc Dec 28, 2018

cabad11 Dec 28, 2018 •

edited

Loading

neSpecc Dec 28, 2018

neSpecc Dec 28, 2018

neSpecc Dec 28, 2018

neSpecc Dec 28, 2018

neSpecc Dec 28, 2018

neSpecc Dec 30, 2018

neSpecc Dec 30, 2018

neSpecc Dec 30, 2018

neSpecc Jan 3, 2019

	let pagesAvailable = await Pages.getAllExceptChildrends(pageId);
	let pagesAvailable = await Pages.getAllExceptChildrens(pageId);

	* Return all pages without children pages
	* Return all pages without children of passed page

	* @param {Array<?Page>} pagesAvailable - Array of all pages
	* @param {Page[]} [pagesAvailable] - Array of all pages

Don't allow to set child element as parent. #19

Don't allow to set child element as parent. #19

Conversation

cabad11 commented Dec 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cabad11 Dec 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cabad11 Dec 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cabad11 Dec 28, 2018 •

edited

Loading

cabad11 Dec 28, 2018 •

edited

Loading