Search #145
Open
Search #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigafiga21
requested review from
gohabereg,
n0str,
neSpecc and
talyguryn
as code owners
neSpecc
requested changes
Feb 22, 2018
| let found = this.DOM.notes.found, | ||
| parent = found.parentNode; | ||
|
|
||
| this.DOM.notes.found = parent.removeChild(found).cloneNode(false); |
|
|
||
| /** | ||
| * Push note data to array where search will be done | ||
| * @param {Object} data - data to push to the dataset |
| pushData( data ) { | ||
| let existingDataIndex = this.dataset.length; | ||
|
|
||
| this.dataset.forEach((item, index) => { |
|
|
||
| /** | ||
| * Remove note data from array where search will be done | ||
| * @param {Object} dataId - the id of data to remove from the dataset |
| * @param {Object} dataId - the id of data to remove from the dataset | ||
| */ | ||
| removeData( dataId ) { | ||
| let existingDataIndex = this.dataset.length; |
| @@ -19,28 +27,35 @@ | |||
| .aside__scrollable | |||
| .aside__scrollable-content(name="js-scrollable") | |||
|
|
|||
| .aside__section-title Folders | |||
| .aside__content-wrap(name="js-folders-container") | |||
| @@ -0,0 +1,13 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| //- | ||
| //- div.notes-list__scroll | ||
| //- | ||
| ul.notes-list__content(name="js-found-notes-menu", tabindex="0") |
There was a problem hiding this comment.
скрывать поиск после очистки инпута
| if (!noteData.title) { | ||
| console.warn('Can not add Note to the Aside because it has no title', noteData); | ||
| return; | ||
| } | ||
|
|
||
| if (searchData) { | ||
| notesMenu = document.querySelector('[name="js-found-notes-menu"]'); |
| let item = $.make('li'); | ||
|
|
||
| if (highlight) { | ||
| item.innerHTML = title.substring(0, highlight.start) + |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a search field.