[Feature] Block Tunes API #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feature/block-tunes
…nto feature/block-tunes
…nto feature/block-tunes
|
Is there any time estimation when this will go into the main branch? |
neSpecc
reviewed
Mar 25, 2021
src/components/block/index.ts
Outdated
| [...this.tunesInstances.values(), ...this.defaultTunesInstances.values()] | ||
| .forEach((tune) => { | ||
| if (_.isFunction(tune.wrap)) { | ||
| wrappedContentNode = tune.wrap(wrappedContentNode); |
There was a problem hiding this comment.
do we need to add try-catch statement here? To avoid rendering problems in case of an error on the tune side?
There was a problem hiding this comment.
same thing at the save() method
neSpecc
reviewed
Apr 1, 2021
| @@ -237,10 +237,13 @@ export default class BlockSettings extends Module<BlockSettingsNodes> { | |||
| } | |||
|
|
|||
| /** | |||
| * Add default settings | |||
| * Add external tunes: provided by user and default ones | |||
There was a problem hiding this comment.
why external? Looks like it appends both internal and external
khaydarov
reviewed
Apr 1, 2021
src/components/tools/tune.ts
Outdated
| * @param data - Tune data | ||
| * @param block - Block API object | ||
| */ | ||
| public instance(data: BlockTuneData, block: BlockAPI): IBlockTune { |
There was a problem hiding this comment.
i think create or build is more suitable here (for function name)
Co-authored-by: Peter Savchenko <specc.dev@gmail.com>
neSpecc
reviewed
Apr 2, 2021
Co-authored-by: Peter Savchenko <specc.dev@gmail.com>
Co-authored-by: Peter Savchenko <specc.dev@gmail.com>
khaydarov
reviewed
Apr 3, 2021
khaydarov
reviewed
Apr 3, 2021
| /** | ||
| * Returns true if Tools is block | ||
| */ | ||
| public isBlock(): this is BlockTool { |
There was a problem hiding this comment.
maybe it is better to rename this method to isBlockTool? because Block is a product of a tool
There was a problem hiding this comment.
Usage would be tool.isBlock(), so I think it's ok
khaydarov
approved these changes
Apr 3, 2021
Co-authored-by: Murod Khaydarov <murod.haydarov@gmail.com>
neSpecc
approved these changes
Apr 4, 2021
* Add tests for tools utils and coverage report * Fix eslint * Adjust test * Add more tests * Update after code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.