Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary aliasing of OneDimensionalArray #161 #165

Merged
merged 4 commits into from
Mar 17, 2020

Conversation

ShebinJoseph
Copy link
Contributor

@ShebinJoseph ShebinJoseph commented Mar 17, 2020

References to other Issues or PRs or Relevant literature

Fixes #161

Brief description of what is fixed or changed

Other comments

@ShebinJoseph
Copy link
Contributor Author

please review the pull request and do the needfull

@czgdp1807
Copy link
Member

The tests are failing because there are multiple files where this aliasing was used. Places where ODA is written should be replaced with OneDimensionalArray along with correcting the imports in those files.

@czgdp1807 czgdp1807 added easy and removed beginner labels Mar 17, 2020
@ShebinJoseph
Copy link
Contributor Author

all places where ODA is written should be interchanged to OneDimensionalArray,right ?

@ShebinJoseph
Copy link
Contributor Author

I interchanged it,but when I runed it, I got a errors like
Instance of 'OneDimensionalArray' has no '_num' member
Instance of 'ArrayForTrees' has no '_load_factor' member
Access to member '_last_pos_filled' before its definition line 224
Whats the issue ?

@ShebinJoseph
Copy link
Contributor Author

I changed it and commited again,but the fail is not going

@@ -48,8 +48,8 @@ class OneDimensionalArray(Array):
Examples
========

>>> from pydatastructs import OneDimensionalArray as ODA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe doctest is failing because u removed the import.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be restored.

@HarsheetKakar
Copy link
Contributor

remove trailing whitespaces and make changes in test_array.py

@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #165 into master will increase coverage by 0.082%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master      #165       +/-   ##
=============================================
+ Coverage   98.328%   98.410%   +0.082%     
=============================================
  Files           21        22        +1     
  Lines         1615      1699       +84     
=============================================
+ Hits          1588      1672       +84     
  Misses          27        27               
Impacted Files Coverage Δ
pydatastructs/linear_data_structures/arrays.py 100.000% <100.000%> (ø)
pydatastructs/graphs/graph.py 100.000% <0.000%> (ø)
pydatastructs/utils/__init__.py 100.000% <0.000%> (ø)
pydatastructs/graphs/__init__.py 100.000% <0.000%> (ø)
pydatastructs/graphs/algorithms.py 100.000% <0.000%> (ø)
pydatastructs/graphs/adjacency_list.py 100.000% <0.000%> (ø)
pydatastructs/graphs/adjacency_matrix.py 100.000% <0.000%> (ø)
...astructs/miscellaneous_data_structures/__init__.py 100.000% <0.000%> (ø)
...ucts/miscellaneous_data_structures/disjoint_set.py 100.000% <0.000%> (ø)
pydatastructs/utils/misc_util.py 97.674% <0.000%> (+0.238%) ⬆️

Impacted file tree graph

@czgdp1807
Copy link
Member

Thanks.

@czgdp1807 czgdp1807 merged commit eea0cdc into codezonediitj:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary aliasing of OneDimensionalArray
3 participants