Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDM (in place) webdav implementation so it gracefully handles network disconnects #4268

Closed
Kjames5269 opened this issue Jan 29, 2019 · 3 comments
Labels
👞Bug Fix 🏬 Release Branch PR to something other than master

Comments

@Kjames5269
Copy link
Contributor

Description

Upon a network disconnect the current webdav implementation will stop all processing when an error occurs and throws an error to the console. The problem occurs that the state, at least when the metacards are being created, only updates once the entire operation finishes. This can lead to inconsistent states where multiple metacards exist per webdav entry. This is also a problem with delete and potentially a problem for modifications.

Steps to Reproduce (if issue is bug)

  1. Start up a webdav server, (follow the directions here to set it up over Tomcat)
  2. set a breakpoint in the code @ DavAlterationObserver#177
  3. Set up CDM to point to the webdav server
  4. Ingest one or two metacards and then shutdown the tomcat server. (Press play one or two times)
  5. wait until the error is thrown
  6. Start the tomcat server again
  7. Query for the metacard, and note there are two of them.

Expected behavior:

The state gets updated after a process successfully completes.
There is only one metacard after a disconnect and reconnect.

Actual behavior:

The state gets updated at the end of the batch.
There are multiple metacards after a disconnect and reconnect

Reproduces how often:

100%

Version

This is a problem on both the [2.13.x], and [master] branches, along with any branch cut from those.

Additional Information

Any additional information, configuration or data that might be necessary
to reproduce the issue.

@coyotesqrl coyotesqrl added this to In progress in GH Issues Pilot Test Jan 29, 2019
@coyotesqrl coyotesqrl moved this from In progress to To do in GH Issues Pilot Test Jan 29, 2019
@coyotesqrl coyotesqrl added 👞Bug Fix 🏬 Release Branch PR to something other than master labels Jan 29, 2019
Kjames5269 added a commit to Kjames5269/ddf that referenced this issue Jan 29, 2019
…ng the interface groundwork to reuse CompletionSynchronization for multiple purposes.
@Kjames5269
Copy link
Contributor Author

apologizes on the commit message, these changes will depend upon #4223

Kjames5269 added a commit to Kjames5269/ddf that referenced this issue Jan 29, 2019
Kjames5269 added a commit to Kjames5269/ddf that referenced this issue Feb 7, 2019
@Kjames5269
Copy link
Contributor Author

Stopping work on this issue.

@shaundmorris
Copy link
Member

Closing this issue since work has stopped on it over a year ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👞Bug Fix 🏬 Release Branch PR to something other than master
Projects
No open projects
Development

No branches or pull requests

3 participants