-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDF-4429 Fixed shared workspace deletion reminder #4202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the extra call to the backend if we already have the workspace data?
If we do, we need to account for possible error responses, as well as response time.
@andrewkfiedler Originally the workspace model was being updated from sharing however the sharing component is generic enough to be used for other types of metacards so it has the potential to be used downstream for other things. The reason we have to request the metacard is for the use case where sharing preferences are updated and then the user attempts to delete the workspace without a refresh in between. |
@Bellcc if the user updates the sharing in app shouldn't we be able to update the sharing preferences at that point? |
@andrewkfiedler Originally this is what this feature did however the We could have a control structure in
|
@Bellcc I think even the other models that reuse the sharing component probably need to be updated based on changes to the sharing though. Each component using it could pass in a callback that takes in the changes and uses those to update themselves as they see fit. The alternative is going to be harder, where we would have to account for possible latency requesting the current state of sharing. |
@andrewkfiedler I updated this PR so that it can properly handle sharing updates too. Since I modified the props for |
build now |
Internal build has been scheduled, your results will be available at build completion. |
Refer to this link for build results (access rights to CI server needed): |
ui/packages/catalog-ui-search/src/main/webapp/react-component/container/sharing/sharing.tsx
Outdated
Show resolved
Hide resolved
build now |
Internal build has been scheduled, your results will be available at build completion. |
Refer to this link for build results (access rights to CI server needed): |
Hero Successful 🎉
|
What does this PR do?
Who is reviewing it?
@cantstoptheunk
@Corey-Collins
Select relevant component teams:
@codice/ui
Ask 2 committers to review/merge the PR and tag them here.
@andrewkfiedler
@djblue
How should this be tested?
Any background context you want to provide?
What are the relevant tickets?
Reusing this ticket number
[DDF-4429](https://codice.atlassian.net/browse/DDF- 4429)
Screenshots
Checklist:
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: