Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.13.x] DDF-4703 updated docs module to add version checking #4707

Merged
merged 1 commit into from Apr 26, 2019

Conversation

ricklarsen
Copy link

What does this PR do?

Reconfigures the directory structure of the documentation build to include version number to prevent issues on quickbuilds or releases

Who is reviewing it?

@ahoffer @austinsteffes @Kjames5269

Select relevant component teams:

@codice/build
@codice/docs

Ask 2 committers to review/merge the PR and tag them here.

@brjeter
@clockard
@lessarderic
@mcalcote
@ricklarsen - Documentation

How should this be tested?

  • check out master branch
  • build docs module with mvn clean install
  • check out this branch
  • build docs module with mvn install (leave previous build artifacts in target directory)

Any background context you want to provide?

What are the relevant tickets?

For GH Issues:
#4703

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@emmberk emmberk changed the title DDF-4703 updated docs module to add version checking [2.13.x] DDF-4703 updated docs module to add version checking Apr 18, 2019
@ricklarsen ricklarsen added this to the 2.13.9 milestone Apr 22, 2019
@ricklarsen ricklarsen added this to In progress in Documentation Pilot via automation Apr 22, 2019
@ricklarsen
Copy link
Author

build now

@cxbot
Copy link

cxbot commented Apr 23, 2019

Internal build has been scheduled, your results will be available at build completion.

@brjeter
Copy link
Contributor

brjeter commented Apr 23, 2019

Hero Successful ✅

@cxbot
Copy link

cxbot commented Apr 23, 2019

Refer to this link for build results (access rights to CI server needed):
https://jenkins.codice.org/job/DDF-Jobs/job/2.13.x/job/pr/job/Linux/710/

Build result: FAILURE

[...truncated 4.97 MB...] at hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.doRun(MavenModuleSetBuild.java:908) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:504) at hudson.model.Run.execute(Run.java:1727) at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:543) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429)ERROR: Step ‘Archive the artifacts’ failed: no workspace for DDF-Jobs/2.13.x/pr/Linux #710[BFA] Scanning build for known causes...[BFA] No failure causes found[BFA] Done. 8sERROR: mesos-jenkins-be84498478264e34a7b9e51bad52cac4-linux-large is offline; cannot locate jdk8-latestERROR: mesos-jenkins-be84498478264e34a7b9e51bad52cac4-linux-large is offline; cannot locate Maven 3.3.9ERROR: mesos-jenkins-be84498478264e34a7b9e51bad52cac4-linux-large is offline; cannot locate jdk8-latestERROR: mesos-jenkins-be84498478264e34a7b9e51bad52cac4-linux-large is offline; cannot locate Maven 3.3.9Adding one-line test results to commit status...ERROR: mesos-jenkins-be84498478264e34a7b9e51bad52cac4-linux-large is offline; cannot locate jdk8-latestERROR: mesos-jenkins-be84498478264e34a7b9e51bad52cac4-linux-large is offline; cannot locate Maven 3.3.9ERROR: mesos-jenkins-be84498478264e34a7b9e51bad52cac4-linux-large is offline; cannot locate jdk8-latestERROR: mesos-jenkins-be84498478264e34a7b9e51bad52cac4-linux-large is offline; cannot locate Maven 3.3.9ERROR: mesos-jenkins-be84498478264e34a7b9e51bad52cac4-linux-large is offline; cannot locate jdk8-latestERROR: mesos-jenkins-be84498478264e34a7b9e51bad52cac4-linux-large is offline; cannot locate Maven 3.3.9Setting status of 290ff83 to FAILURE with url https://jenkins.codice.org/job/DDF-Jobs/job/2.13.x/job/pr/job/Linux/710/ and message: 'JOB FAILURE: https://jenkins.codice.org/job/DDF-Jobs/job/2.13.x/job/pr/job/Linux/710/ 2 tests run, 0 skipped, 0 failed.'Using context: Internal CI Pipeline
❌ JOB FAILURE

@brjeter
Copy link
Contributor

brjeter commented Apr 26, 2019

build now

@cxbot
Copy link

cxbot commented Apr 26, 2019

Internal build has been scheduled, your results will be available at build completion.

@brjeter
Copy link
Contributor

brjeter commented Apr 26, 2019

✅ Hero successful

@ricklarsen ricklarsen merged commit dd7f54c into codice:2.13.x Apr 26, 2019
Documentation Pilot automation moved this from In progress to Done Apr 26, 2019
@cxbot
Copy link

cxbot commented Apr 26, 2019

Refer to this link for build results (access rights to CI server needed):
https://jenkins.codice.org/job/DDF-Jobs/job/2.13.x/job/pr/job/Linux/713/
❌ JOB FAILURE

@ricklarsen ricklarsen deleted the DDF-4703-2.13.x branch April 26, 2019 17:53
ricklarsen pushed a commit to ricklarsen/ddf that referenced this pull request Apr 29, 2019
@brjeter brjeter modified the milestones: 2.13.9, 2.13.10 Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants