DDF-4903 Fix render loop caused by poller in dropdown.js #4906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a render loop in dropdown.js caused by React's equality check not being sufficient for this model.
Who is reviewing it?
@samuelechu @mojogitoverhere
Select relevant component teams:
@codice/ui
Ask 2 committers to review/merge the PR and tag them here.
@djblue
@vinamartin
How should this be tested?
Open a component using react-comppnent/dropdown/dropdown.js
Throw a debug in that component's render method.
Ensure that the debug isn't hit constantly.
Any background context you want to provide?
What are the relevant tickets?
Fixes: #4903
Checklist:
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: